starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-07-08 17:56:58 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

[PR #1393] Fix one-off in dcheck. #2005

New Issue
Open
opened 2026-01-29 20:56:53 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 20:56:53 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/google/brotli/pull/1393

State: closed
Merged: Yes

Fix one-off in dcheck.

How to prove correctness:

  1. when position is 0, max_length is allowed to be ringbuffer_size
  2. in other words: position + max_length <= ringbuffer_size
  3. ringbuffer_mask == ringbuffer_size - 1
  4. thus position + max_length <= ringbuffer_size + 1
**Original Pull Request:** https://github.com/google/brotli/pull/1393 **State:** closed **Merged:** Yes --- Fix one-off in dcheck. How to prove correctness: 1) when `position` is `0`, `max_length` is allowed to be `ringbuffer_size` 2) in other words: `position + max_length <= ringbuffer_size` 3) `ringbuffer_mask == ringbuffer_size - 1` 4) thus `position + max_length <= ringbuffer_size + 1`
claunia added the pull-request label 2026-01-29 20:56:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#2005
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?