starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-07-08 17:56:58 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

Completion of error handling #22

New Issue
Closed
opened 2026-01-29 20:29:10 +00:00 by claunia · 7 comments
claunia commented 2026-01-29 20:29:10 +00:00
Owner
Copy Link

Originally created by @elfring on GitHub (Sep 11, 2015).

Would you like to add more error handling for return values from functions like the following?

Originally created by @elfring on GitHub (Sep 11, 2015). Would you like to add more error handling for return values from functions like the following? - [fseek](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html) ⇒ [FileSize](https://github.com/google/brotli/blob/7f7a2fb48cec63c0459ec6b6e7260810bfb01819/tools/bro.cc#L160) - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [BrotliFileIn constructor](https://github.com/google/brotli/blob/55a40ce214be844b8860ef46e3ba321324542679/enc/streams.cc#L90)
claunia commented 2026-01-29 20:29:11 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (Oct 6, 2015):

Fixed. Thank you!

@eustas commented on GitHub (Oct 6, 2015): Fixed. Thank you!
claunia commented 2026-01-29 20:29:11 +00:00
Author
Owner
Copy Link

@elfring commented on GitHub (Oct 6, 2015):

To which commits do you refer to for this issue?

@elfring commented on GitHub (Oct 6, 2015): To which commits do you refer to for this issue?
claunia commented 2026-01-29 20:29:11 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (Oct 6, 2015):

https://github.com/google/brotli/pull/209

@eustas commented on GitHub (Oct 6, 2015): https://github.com/google/brotli/pull/209
claunia commented 2026-01-29 20:29:11 +00:00
Author
Owner
Copy Link

@elfring commented on GitHub (Oct 6, 2015):

Are there any update candidates left over?

@elfring commented on GitHub (Oct 6, 2015): Are there [any update candidates](https://github.com/google/brotli/blob/c85bb508cb86eaac98a4667e67e944018f5abbf2/tools/bro.cc#L185) left over?
claunia commented 2026-01-29 20:29:12 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (Oct 6, 2015):

This one looks safe, since we haven't touched the file contents.
Will fix it soon.

@eustas commented on GitHub (Oct 6, 2015): This one looks safe, since we haven't touched the file contents. Will fix it soon.
claunia commented 2026-01-29 20:29:12 +00:00
Author
Owner
Copy Link

@szabadka commented on GitHub (Oct 23, 2015):

Fixed in PR #235

@szabadka commented on GitHub (Oct 23, 2015): Fixed in PR #235
claunia commented 2026-01-29 20:29:12 +00:00
Author
Owner
Copy Link

@elfring commented on GitHub (Oct 23, 2015):

Thanks for another small source code improvement.

@elfring commented on GitHub (Oct 23, 2015): Thanks for another small source code improvement.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#22
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?