Different dictionary.h files? #23

New Issue

claunia · 2026-01-29T20:29:12Z

claunia commented

2026-01-29 20:29:12 +00:00

Originally created by @ericlaw1979 on GitHub (Sep 8, 2015).

Shouldn't \dec\dictionary.h and \enc\dictionary.h be identical?

https://github.com/google/brotli/blob/master/enc/dictionary.h looks like it may be out-of-date; it doesn't include, e.g. the

#if defined(__cplusplus) || defined(c_plusplus)
}    /* extern "C" */
#endif

...block at the end, for instance.

(Incidentally, declaration of the constant in a header file is apparently frowned upon per people smarter than me. Naively building brotli.exe with VS2015 results in 6 copies of the constant array in the resulting executable.)

Originally created by @ericlaw1979 on GitHub (Sep 8, 2015). Shouldn't `\dec\dictionary.h` and `\enc\dictionary.h` be identical? https://github.com/google/brotli/blob/master/enc/dictionary.h looks like it may be out-of-date; it doesn't include, e.g. the ``` #if defined(__cplusplus) || defined(c_plusplus) } /* extern "C" */ #endif ``` ...block at the end, for instance. (Incidentally, declaration of the constant in a header file is apparently frowned upon per people smarter than me. Naively building brotli.exe with VS2015 results in _6_ copies of the constant array in the resulting executable.)

claunia closed this issue

2026-01-29 20:29:12 +00:00

claunia commented

2026-01-29 20:29:13 +00:00

@lvandeve commented on GitHub (Sep 21, 2015):

Thank you for reporting this. We'll fix it soon.

@lvandeve commented on GitHub (Sep 21, 2015): Thank you for reporting this. We'll fix it soon.

claunia commented

2026-01-29 20:29:13 +00:00

@szabadka commented on GitHub (Oct 1, 2015):

This is fixed in PR #187

@szabadka commented on GitHub (Oct 1, 2015): This is fixed in PR #187