starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-07-08 17:56:58 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

MSVC C4551 compiler warnings in platform.h #236

New Issue
Closed
opened 2026-01-29 20:40:25 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 20:40:25 +00:00
Owner
Copy Link

Originally created by @rvandermeulen on GitHub (May 31, 2018).

I was taking a look at updating Firefox' vendored copy of brotli to version 1.0.4 today.

Along the way, I ran into Werror bustage in platform.h within the newly-added BROTLI_UNUSED_FUNCTION void BrotliSuppressUnusedFunctions(void) block. MSVC gives a "warning C4551: function call missing argument list" error for each subsequent line within it.

The warning is fixable by explicitly making those all references instead, i.e. BROTLI_UNUSED(&BrotliSuppressUnusedFunctions) instead of BROTLI_UNUSED(BrotliSuppressUnusedFunctions). As far as I can tell, everything compiles and functions fine with GCC and clang as well with this change.

Originally created by @rvandermeulen on GitHub (May 31, 2018). I was taking a look at updating Firefox' vendored copy of brotli to version 1.0.4 today. Along the way, I ran into Werror bustage in platform.h within the newly-added `BROTLI_UNUSED_FUNCTION void BrotliSuppressUnusedFunctions(void)` block. MSVC gives a "warning C4551: function call missing argument list" error for each subsequent line within it. The warning is fixable by explicitly making those all references instead, i.e. `BROTLI_UNUSED(&BrotliSuppressUnusedFunctions)` instead of `BROTLI_UNUSED(BrotliSuppressUnusedFunctions)`. As far as I can tell, everything compiles and functions fine with GCC and clang as well with this change.
claunia commented 2026-01-29 20:40:26 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (Jun 4, 2018):

Going to do that soon. Thanks for reporting.

@eustas commented on GitHub (Jun 4, 2018): Going to do that soon. Thanks for reporting.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#236
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?