starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-09-22 14:45:51 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

fuzz directory to have C sources instead of C++ #237

New Issue
Closed
opened 2026-01-29 20:40:28 +00:00 by claunia · 5 comments
claunia commented 2026-01-29 20:40:28 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Jun 10, 2018).

ref https://github.com/dotnet/corefx/issues/30249
We are in process of converting some C++ sources in corefx and found that fuzz directory, that lives under c has two c++ sources 8544ae858d/c/fuzz. Could these two .cc's be updated to C?

Originally created by @ghost on GitHub (Jun 10, 2018). ref https://github.com/dotnet/corefx/issues/30249 We are in process of converting some C++ sources in corefx and found that `fuzz` directory, that lives under `c` has two `c++` sources https://github.com/google/brotli/tree/8544ae858d87056c8dac55713ffe148d9c60eb93/c/fuzz. Could these two `.cc`'s be updated to `C`?
claunia commented 2026-01-29 20:40:29 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (Jun 10, 2018):

I'll check in on Monday. Alternatively, it could be moved from c/fuzz, to fuzz/ or somewhere else.

@eustas commented on GitHub (Jun 10, 2018): I'll check in on Monday. Alternatively, it could be moved from c/fuzz, to fuzz/ or somewhere else.
claunia commented 2026-01-29 20:40:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 10, 2018):

Thanks @eustas. I have sent a PR to purge C++'ism from fuzz https://github.com/google/brotli/pull/682. However, I don't have Google Account to sign the CLA with. Feel free to use this patch as a public domain contribution. :)

@ghost commented on GitHub (Jun 10, 2018): Thanks @eustas. I have sent a PR to purge C++'ism from fuzz https://github.com/google/brotli/pull/682. However, I don't have Google Account to sign the CLA with. Feel free to use this patch as a public domain contribution. :)
claunia commented 2026-01-29 20:40:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 14, 2018):

@eustas, have you had a chance to look at it?

@ghost commented on GitHub (Jun 14, 2018): @eustas, have you had a chance to look at it?
claunia commented 2026-01-29 20:40:30 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 18, 2018):

Fixed by #686.

@ghost commented on GitHub (Jun 18, 2018): Fixed by #686.
claunia commented 2026-01-29 20:40:30 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (Jun 22, 2018):

Release is postponed a little bit; oss-fuzz failed to build the new binary (clang++ said that it does not like std=c99, and then clang failed to link with c++ fuzzer library)... Hopefully all things will work together on this weekend -> v1.0.5 will be released on Monday.

@eustas commented on GitHub (Jun 22, 2018): Release is postponed a little bit; oss-fuzz failed to build the new binary (clang++ said that it does not like std=c99, and then clang failed to link with c++ fuzzer library)... Hopefully all things will work together on this weekend -> v1.0.5 will be released on Monday.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#237
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?