Visibility of brotli APIs on Unix #239

New Issue

claunia · 2026-01-29T20:40:31Z

claunia commented

2026-01-29 20:40:31 +00:00

Originally created by @ghost on GitHub (Jun 19, 2018).

For Unix, we had to apply this patch to set the visibility of BROTLI_ENC_API dotnet/corefx@0c770ca72d. This happens when downstream is compiling with -fvisibility=hidden. We have out-of-the-tree cmake file that includes Brotli's sources.

@eustas, could this patch be also considered for Brotli vNext? AFAICT, there are no ramifications of this change, when the consumer doesn't have -fvisibility set.

Originally created by @ghost on GitHub (Jun 19, 2018). For Unix, we had to apply this patch to set the visibility of BROTLI_ENC_API dotnet/corefx@0c770ca72daf50ad12703b175dcb83e306664ba6. This happens when downstream is compiling with `-fvisibility=hidden`. We have out-of-the-tree cmake file that includes Brotli's sources. @eustas, could this patch be also considered for Brotli vNext? AFAICT, there are no ramifications of this change, when the consumer doesn't have `-fvisibility` set.

claunia closed this issue

2026-01-29 20:40:31 +00:00

claunia commented

2026-01-29 20:40:31 +00:00

@eustas commented on GitHub (Jun 19, 2018):

Sure. Perhaps with a little bit different enclosure, i.e.

if shared
  if win32
    XXX
  else
    YYY
else
  ZZZ

@eustas commented on GitHub (Jun 19, 2018): Sure. Perhaps with a little bit different enclosure, i.e. ``` if shared if win32 XXX else YYY else ZZZ ```

claunia commented

2026-01-29 20:40:32 +00:00

@ghost commented on GitHub (Jun 19, 2018):

That would certainly improve readability. 👍

@ghost commented on GitHub (Jun 19, 2018): That would certainly improve readability. 👍

claunia commented

2026-01-29 20:40:32 +00:00

@eustas commented on GitHub (Jun 20, 2018):

Should be fixed with #688

@eustas commented on GitHub (Jun 20, 2018): Should be fixed with #688

claunia commented

2026-01-29 20:40:32 +00:00