mirror of
https://github.com/google/brotli.git
synced 2026-07-08 17:56:58 +00:00
Intel Compiler 18 Regression #243
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Johnex on GitHub (Jun 29, 2018).
Hi!
I downloaded the latest 1.0.5 release, built it like so:
In the latest version now BROTLI_INLINE is undefined, causing the compile to fail:
With the same commands above, 1.0.4 builds fine:
@eustas commented on GitHub (Jun 29, 2018):
Going to dig into it on Monday.
Unfortunately, there is no publicly available icc, so this might be very difficult =(
@Johnex commented on GitHub (Jun 29, 2018):
You can download the demo of Parallel Studio XE :D, and they also have an open source program. If you apply this project im sure they would accept and send you a free license.
@Johnex commented on GitHub (Jun 29, 2018):
https://software.intel.com/en-us/qualify-for-free-software/opensourcecontributor
@eustas commented on GitHub (Jun 29, 2018):
I've asked Intel. Unfortunately, as a Google employee I can not qualify as open-source developer =(
@Johnex commented on GitHub (Jun 29, 2018):
Since its just to make the project compile and not for commercial use as in binaries etc, im sure that would be ok. I don't think it would take you more than 7 days to see whats wrong either.
I might be able to set up a VM with my license if you can't figure it out, let me know.
@JoeUX commented on GitHub (Jul 13, 2018):
Also, anyone who happens to be a student can get Parallel Studio for free, all the way up to Cluster Edition.
@eustas commented on GitHub (Oct 22, 2018):
Found a way around the license limitations:
https://godbolt.org/But currently both icc 18.0.0 and 19.0.0 work well for sample piece of code. Going to play with compilation options...
@eustas commented on GitHub (Oct 22, 2018):
BTW godbolt gives a clue why MSVC-compiled code could be 2x slower - compiler simply ignores inlining request.
... Never mind. It inlines only when "-O" option is passed, while other compilers do it without options.
@eustas commented on GitHub (Oct 22, 2018):
-m32does not break the build. Perhaps there is something poisonous injected by CMake.To debug this it would be nice to have more verbose output and, ideally, preprocessed
platform.h...@eustas commented on GitHub (Oct 22, 2018):
(github ate my comments )=
In short - it is possible to try
iccusing godbolt. (Un)fortunately, it compiles code snippets well -> CMake/msbuild do something outrageous... To debug this, verbose output and, ideally, preprocessedplatform.his required.@Johnex commented on GitHub (Oct 25, 2018):
You are not able to just download the trial version of Parallel Studio XE? I think it was 7 day trial, enough to check cmake issues?
@eustas commented on GitHub (Oct 25, 2018):
It is 30 days, but:
@Johnex commented on GitHub (Oct 25, 2018):
I'm pretty sure you would see the issue in a Windows VM running in Linux.
@eustas commented on GitHub (Oct 26, 2018):
Last ~50 lines of
icc -E -dM -Iinclude common/platform.hwould shed the light on the problem.Also full output of
icc -E -Iinclude common/platform.hwould be useful.(both commands run in
brotli/cdirectory)@Johnex commented on GitHub (Oct 26, 2018):
The command is icl, and replacing icc with icl just outputted the file contents, did nothing. Here is the help for icl:
@Johnex commented on GitHub (Oct 26, 2018):
Full build procedure:
@Johnex commented on GitHub (Oct 15, 2019):
I will close this since i have been using the Visual Studio Compiler instead, and that is flawless.
The Intel Compiler has a lot of bugs they are slow to fix so not worth using honestly.