mirror of
https://github.com/google/brotli.git
synced 2026-07-08 17:56:58 +00:00
Add brotli mime type detection to file and libmagic #259
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @stokito on GitHub (Oct 27, 2018).
The Linux
fileutility doesn't recognize brotli MIME type:I know, this is not related for the brotli itself but could you send a PR to file and libmagic so they start to recognize brotli mime type?
https://github.com/file/file/blob/master/src/compress.c
https://github.com/file/file/blob/master/magic/Magdir/archive
Also please confirm the correct brotli mime type #724
@eustas commented on GitHub (Nov 1, 2018):
There is a little problem. Most utilities scan first file bytes and compare them against "magic" bytes.
Well,... for brotli 254 of 256 byte values are valid as the first file byte.
Brotli was designed to be "stream" format rather than file format. There is a "brotli-framing-format" project that adds tons of features (including "magic header bytes")... but it is not public yet.
@stokito commented on GitHub (Nov 1, 2018):
If I understood correctly gzip is also can be named as stream format but this is not a problem for them to add few magic bytes.
I already used
\xce\xb2\xcf\x81as brotli magic bytes andapplication/x-brotlias mime type but asked here #724 to confirm.Where can I read at least something about this framing format? Will we still be able to use regular .br files?
@eustas commented on GitHub (Nov 1, 2018):
gzipis a wrapper fordeflatestreams@stokito commented on GitHub (Nov 10, 2018):
So, the magic bytes which I used are actually from another framing format from #462
@doronbehar commented on GitHub (Oct 6, 2019):
I've opened an issue about this in
file's bug tracker:https://bugs.astron.com/view.php?id=111
So @eustas, the issue is that this implementation doesn't include magic bytes when it creates files and not streams?
@unphased commented on GitHub (Aug 4, 2024):
What is the state of this? Most (but not all! which is not looking promising) of the brotli files i looked at start with the byte
5b...