memmove16 implementation is playing with fire #26

New Issue

claunia · 2026-01-29T20:29:15Z

claunia commented

2026-01-29 20:29:15 +00:00

Originally created by @rygorous on GitHub (Sep 22, 2015).

As already noted in the code https://github.com/google/brotli/blob/master/dec/decode.c#L89, assuming details about the memcpy implementation and optimizations is playing with fire. Maybe introduce a BROTLI_NO_DANGEROUS_OPTIMIZATIONS #define that avoids this kind of code path, to ease porting to non-mainstream architectures?

Originally created by @rygorous on GitHub (Sep 22, 2015). As already noted in the code https://github.com/google/brotli/blob/master/dec/decode.c#L89, assuming details about the memcpy implementation and optimizations is playing with fire. Maybe introduce a BROTLI_NO_DANGEROUS_OPTIMIZATIONS #define that avoids this kind of code path, to ease porting to non-mainstream architectures?

claunia closed this issue

2026-01-29 20:29:15 +00:00

claunia commented

2026-01-29 20:29:16 +00:00

@eustas commented on GitHub (Sep 28, 2015):

Fixed with PR 183.
Compiling with -DBROTLI_BUILD_PORTABLE avoids overlapping memcpy and unaligned reads.

@eustas commented on GitHub (Sep 28, 2015): Fixed with PR 183. Compiling with -DBROTLI_BUILD_PORTABLE avoids overlapping memcpy and unaligned reads.

claunia referenced this issue

2026-01-29 20:46:23 +00:00

[PR #26] [MERGED] Fix a sign-conversion warning in the decoder. #603

Sign in to join this conversation.