mirror of
https://github.com/google/brotli.git
synced 2026-07-09 02:08:06 +00:00
Compatibility test depends on git core.autocrlf set to false #286
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aasivov on GitHub (Jul 11, 2019).
Some compatibility tests fail if git config core.autocrlf is not set to false.
It is so, because these tests decompress the compressed files taken from the repo and compare results with the reference files taken from the repo.
Some of these reference files are .txt files and their line feed on checkout depends on git's autocrlf option. It may result in different line feed in that files and the decompressed files.
For an instance, tests/testdata/asyoulik.txt has LF line feeds and asyoulik.txt.unbr in compatibility test has LF line feeds. However, on windows machine with git config core.autocrlf true tests/testdata/asyoulik.txt has CRLF line feeds after checkout and test fails.
I believe that all files in tests/testdata should always be treated as binary files.
Perhaps, it's worth it to add .gitattributes to the repo and to state it there.
@eustas commented on GitHub (Jul 11, 2019):
Thanks for pinpointing the problem. Going to fix it when I have the next spare moment.