starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-07-08 17:56:58 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

Test vectors of 'asyoulik.txt' and 'asyoulik.txt.compressed' are not aligned each other #288

New Issue
Closed
opened 2026-01-29 20:41:26 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 20:41:26 +00:00
Owner
Copy Link

Originally created by @eugeneilyin on GitHub (Jul 17, 2019).

The compressed version of asyoulik.txt.compressed after decompression gives asyoulik.txt with LF (ASCII 0x0A) line separators.

But the original file asyoulik.txt contains CR LF (ASCII 0x0D 0x0A) line separators.

Please update the compressed version asyoulik.txt.compressed to contain original with CR LF separators as it's presented in other text samples.

Originally created by @eugeneilyin on GitHub (Jul 17, 2019). The compressed version of [asyoulik.txt.compressed](https://github.com/google/brotli/blob/master/tests/testdata/asyoulik.txt.compressed) after decompression gives `asyoulik.txt` with `LF` (ASCII 0x0A) line separators. But the original file [asyoulik.txt](https://github.com/google/brotli/blob/master/tests/testdata/asyoulik.txt) contains `CR LF` (ASCII 0x0D 0x0A) line separators. Please update the compressed version `asyoulik.txt.compressed` to contain original with `CR LF` separators as it's presented in other text samples.
claunia commented 2026-01-29 20:41:27 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (Jul 18, 2019):

Does that happen with clean checkout after #761?

@eustas commented on GitHub (Jul 18, 2019): Does that happen with clean checkout after #761?
claunia commented 2026-01-29 20:41:27 +00:00
Author
Owner
Copy Link

@eugeneilyin commented on GitHub (Jul 18, 2019):

@eustas, I see that test vectors were changed. The compression/decompression checks with all levels of Quality and WindowBits were passed on all new samples. This issue can be closed. Thanks for the fix.

@eugeneilyin commented on GitHub (Jul 18, 2019): @eustas, I see that test vectors were changed. The compression/decompression checks with all levels of `Quality` and `WindowBits` were passed on all new samples. This issue can be closed. Thanks for the fix.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#288
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?