Error groups #289

New Issue

claunia · 2026-01-29T20:41:27Z

claunia commented

2026-01-29 20:41:27 +00:00

Originally created by @andrew-aladev on GitHub (Sep 12, 2019).

Hello. I see brotli provides a wide list of errors:

#define BROTLI_DECODER_ERROR_CODES_LIST...
/* Errors caused by invalid input */
...
/* Memory allocation problems */
...

Today all these error codes have only one group: BROTLI_DECODER_RESULT_ERROR.

static BROTLI_NOINLINE BrotliDecoderResult SaveErrorCode(
  BrotliDecoderState* s, BrotliDecoderErrorCode e) {
  ...
  switch (e) {
    ...
    default:
      return BROTLI_DECODER_RESULT_ERROR;
  } 
}

So if user want to know when decoder received corrupted source he have to list all 16 codes. It makes too tight and unreliable connection between brotli implementation and application.

Can you please provide several error groups like: BROTLI_DECODER_RESULT_CORRUPTED_SOURCE, BROTLI_DECODER_RESULT_ALLOCATION_FAILED and etc? Thank you.

Originally created by @andrew-aladev on GitHub (Sep 12, 2019). Hello. I see brotli provides a wide list of errors: ``` #define BROTLI_DECODER_ERROR_CODES_LIST... /* Errors caused by invalid input */ ... /* Memory allocation problems */ ... ``` Today all these error codes have only one group: `BROTLI_DECODER_RESULT_ERROR`. ``` static BROTLI_NOINLINE BrotliDecoderResult SaveErrorCode( BrotliDecoderState* s, BrotliDecoderErrorCode e) { ... switch (e) { ... default: return BROTLI_DECODER_RESULT_ERROR; } } ``` So if user want to know when decoder received corrupted source he have to list all **16 codes**. It makes too tight and unreliable connection between brotli implementation and application. Can you please provide several error groups like: `BROTLI_DECODER_RESULT_CORRUPTED_SOURCE`, `BROTLI_DECODER_RESULT_ALLOCATION_FAILED` and etc? Thank you.

claunia referenced this issue

2026-01-29 20:51:27 +00:00

[PR #289] [CLOSED] Updated copyright to 2016 #886

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#289