starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-09-22 06:35:52 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

Release compilation by default #325

New Issue
Closed
opened 2026-01-29 20:42:02 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 20:42:02 +00:00
Owner
Copy Link

Originally created by @riknel on GitHub (Jul 5, 2020).

Hello!
You have a debug version of compilation by default. Wouldn’t it be better if you have a faster(release) version by default?
My concerns are that some developers may not notice the flag for release built and will use subpar Brotli for their compression. I haven’t noticed it at first but speaking with Jyrki Alakuijala helped. I also know that some other people have missed this flag.

Originally created by @riknel on GitHub (Jul 5, 2020). Hello! You have a debug version of compilation by default. Wouldn’t it be better if you have a faster(release) version by default? My concerns are that some developers may not notice the flag for release built and will use subpar Brotli for their compression. I haven’t noticed it at first but speaking with Jyrki Alakuijala helped. I also know that some other people have missed this flag.
claunia commented 2026-01-29 20:42:03 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (Jul 6, 2020):

Hello.
Which build system you are referring to? make / automake / Bazel / Premake / CMake?

The most popular is CMake, and in the readme we explain how to build "Release" version.

Fixing "Release" for Bazel is an anti-pattern.

make is not properly supported as a build system in this repository, as it does not have "configuration" phase.

automake has one; but it builds "Release" version by default IIRC; and Premake too.

@eustas commented on GitHub (Jul 6, 2020): Hello. Which build system you are referring to? `make` / `automake` / `Bazel` / `Premake` / `CMake`? The most popular is `CMake`, and in the readme we explain how to build "Release" version. Fixing "Release" for `Bazel` is an anti-pattern. `make` is not properly supported as a build system in this repository, as it does not have "configuration" phase. `automake` has one; but it builds "Release" version by default IIRC; and `Premake` too.
claunia commented 2026-01-29 20:42:03 +00:00
Author
Owner
Copy Link

@riknel commented on GitHub (Jul 9, 2020):

Mostly about Cmake as usually people use it.
Yes, I've seen that you have an explanation on how to do a release built for Cmake. What I meant is it seems like some people have missed this explanation and used a debug version instead (me and some other people I spoke to). If those people use Brotli for production purposes it may have a huge drop in performance. So I think it's better if the default version would be a release one. What do you think?

@riknel commented on GitHub (Jul 9, 2020): Mostly about Cmake as usually people use it. Yes, I've seen that you have an explanation on how to do a release built for Cmake. What I meant is it seems like some people have missed this explanation and used a debug version instead (me and some other people I spoke to). If those people use Brotli for production purposes it may have a huge drop in performance. So I think it's better if the default version would be a release one. What do you think?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#325
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?