Window.BrotliDecode is not set in decode.min.js #344

Closed
opened 2026-01-29 20:42:19 +00:00 by claunia · 5 comments
Owner

Originally created by @mrpmorris on GitHub (Sep 19, 2020).

The minimised version of decode.js sets

window.ra=BrotliDecode;

when it sould set

window.BrotliDecode = BrotliDecode;
Originally created by @mrpmorris on GitHub (Sep 19, 2020). The minimised version of decode.js sets ``` window.ra=BrotliDecode; ``` when it sould set ``` window.BrotliDecode = BrotliDecode; ```
Author
Owner

@eustas commented on GitHub (Sep 21, 2020):

Hi. In your comment strings only differ by the semicolon.

Though, "min" version looks strange: "BrotliDecodeClosure" is not shortened, and "ra" should be "BrotliDecode".
Going to revise that soon.

@eustas commented on GitHub (Sep 21, 2020): Hi. In your comment strings only differ by the semicolon. Though, "min" version looks strange: "BrotliDecodeClosure" is not shortened, and "ra" should be "BrotliDecode". Going to revise that soon.
Author
Owner

@mrpmorris commented on GitHub (Sep 21, 2020):

@eustas sorry, text was wrong. I've now corrected it

@mrpmorris commented on GitHub (Sep 21, 2020): @eustas sorry, text was wrong. I've now corrected it
Author
Owner

@guardrex commented on GitHub (Jan 17, 2021):

@mrpmorris ... There are updates (google/brotli #852) that apparently will fix this (among other things), but those October updates are in limbo. Microsoft is now seeking to drop the use of this script. We can't depend on unmaintained bits.

@guardrex commented on GitHub (Jan 17, 2021): @mrpmorris ... There are [updates (google/brotli #852)](https://github.com/google/brotli/pull/852) that apparently will fix this (among other things), but those October updates are in limbo. Microsoft is now seeking to drop the use of this script. We can't depend on unmaintained bits.
Author
Owner

@eustas commented on GitHub (Jan 18, 2021):

Sorry, was on a very long leave since October. Going to land that update soon.

@eustas commented on GitHub (Jan 18, 2021): Sorry, was on a very long leave since October. Going to land that update soon.
Author
Owner

@eustas commented on GitHub (Jan 18, 2021):

Should be fixed.

@eustas commented on GitHub (Jan 18, 2021): Should be fixed.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#344