mirror of
https://github.com/google/brotli.git
synced 2026-07-09 02:08:06 +00:00
Source tarball is missing testdata files since v1.0.8 #348
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @delroth on GitHub (Oct 2, 2020).
Something changed between v1.0.7 and v1.0.8 which caused the testdata files to disappear from the source tarball. This means that it's now impossible to run unit tests at least for Python without using a git clone instead.
@delroth commented on GitHub (Oct 2, 2020):
This is because all the files were marked as export-ignore except for a select few. cc @eustas who committed that change
@candrews commented on GitHub (Oct 18, 2020):
Hereare the commit that removed the test data:
f0db711d052918OpenBSD requested that the test data be added back into the PyPI tarball: https://github.com/google/brotli/pull/841 and that was done:
f2ca32eda6So, I think it's logical that the test data also be added back into the source tarball.@wltjr commented on GitHub (Oct 28, 2020):
Much more than just the test data was removed. Other sources like Java sources were removed. They are not part of 1.0.8 or 1.0.9. I will open a new issue regarding that, and refer to this one.
@olivier-fs commented on GitHub (Aug 31, 2023):
Hi !
Bumping this old issue...
Latest CMake-3.27.4 output :
I cloned the repo and copied git 'testdata' to 'brotli-1.1.0/tests/testdata'.
The build is fine but the test targets are not generated even with BROTLI_DISABLE_TESTS undefined.
So : How do I generate and run tests targets?
Thanks !
@eustas commented on GitHub (Sep 5, 2023):
Thanks for the heads-up. Going to add an additional CI workflow to test build from tarball. And, of course fix the problem.
@eustas commented on GitHub (Sep 13, 2023):
Fixed. CMake message is more clear now. TL;DR: run
scripts/download_testdata.shbefore configuring, if building from archive.@candrews commented on GitHub (Sep 13, 2023):
@eustas I think merging https://github.com/google/brotli/pull/857 would have been a nice solution... why not use that approach?
@eustas commented on GitHub (Sep 13, 2023):
Testdata have been removed from archive on purpose - it takes extra 15MiB.
I'm planning publishing our (currently internal) unit-tests soon. Those are better for discovering problems that just round-tripping some random golden files.
@eustas commented on GitHub (Sep 13, 2023):
#747
@olivier-fs commented on GitHub (Sep 22, 2023):
Sorry for being late at reporting status.
I understand the idea of keeping the tarball small by not including testdata.
But not being able to test the binaries was somehow worrying (I'm using my own build of nginx with ngx_brotli, so I first must be sure that my brotli build is fine.)
Indeed everything is now OK with the 'download_testdata.sh' script 👍
Thank you !