mirror of
https://github.com/google/brotli.git
synced 2026-07-08 17:56:58 +00:00
Honor CXXFLAGS when building python module #349
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ryandesign on GitHub (Oct 6, 2020).
Hi. Parts of the brotli python module are written in C++. When compiling that part, the contents of environment variable CXXFLAGS should be passed to the compiler. setuptools does not support modules written in C++ so you have to hack in support manually (or help the setuptools folks fix it on their end, if you're able).
My preliminary fix is here:
b21a2cbb0d/python/py-brotli/files/CXXFLAGS.patchIt may not be fully correct but it was good enough for me on macOS.