Compiler warnings #367

Open
opened 2026-01-29 20:42:47 +00:00 by claunia · 0 comments
Owner

Originally created by @crazydef on GitHub (Jan 5, 2021).

Hi,

When including Brotli headers in our own projects, we're experiencing the following compiler warnings in Visual Studio 2019:

brotli\dec\bit_reader.h(27,47): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(110,74): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(119,75): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(108,41): warning C4100: 'n_bits': unreferenced formal parameter
brotli\dec\bit_reader.h(252,39): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(272,39): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(307,39): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(27,47): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(110,74): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(119,75): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(108,41): warning C4100: 'n_bits': unreferenced formal parameter
brotli\dec\bit_reader.h(252,39): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(272,39): warning C4127: conditional expression is constant
brotli\dec\bit_reader.h(307,39): warning C4127: conditional expression is constant
brotli\dec\huffman.c(124,1): warning C4127: conditional expression is constant
brotli\dec\huffman.c(135,1): warning C4127: conditional expression is constant
brotli\dec\decode.c(1174,7): warning C4127: conditional expression is constant

It'd be nice if we didn't see these in the future. :)

Originally created by @crazydef on GitHub (Jan 5, 2021). Hi, When including Brotli headers in our own projects, we're experiencing the following compiler warnings in Visual Studio 2019: brotli\dec\bit_reader.h(27,47): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(110,74): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(119,75): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(108,41): warning C4100: 'n_bits': unreferenced formal parameter brotli\dec\bit_reader.h(252,39): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(272,39): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(307,39): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(27,47): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(110,74): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(119,75): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(108,41): warning C4100: 'n_bits': unreferenced formal parameter brotli\dec\bit_reader.h(252,39): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(272,39): warning C4127: conditional expression is constant brotli\dec\bit_reader.h(307,39): warning C4127: conditional expression is constant brotli\dec\huffman.c(124,1): warning C4127: conditional expression is constant brotli\dec\huffman.c(135,1): warning C4127: conditional expression is constant brotli\dec\decode.c(1174,7): warning C4127: conditional expression is constant It'd be nice if we didn't see these in the future. :)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#367