mirror of
https://github.com/google/brotli.git
synced 2026-11-17 01:21:42 +00:00
Reversing the project's version variable flow #398
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @the-moisrex on GitHub (Oct 12, 2021).
I have some sort of question about the design of the version variables used in this library. From what I know, it's more usual to put the version number inside the
CMakeLists.txtfile and then use preprocessing to put it in the files likec/common/version.hnot the other way around.Currently there's this kinda CMake code in

CMakeLists.txtfile to do just thatAnd also not knowing the project's version number in the

CMakeLists.txt'sprojectcommand will cause warnings like this:which btw can be fixed by this pull request that I made a few days ago; but I don't think the library versioning should be this complicated.
@eustas commented on GitHub (Jan 6, 2023):
Warning supression landed.
The thing is - CMake is not the only option to build brotli. To place buld systems in equal position we decided to put version in source code.