Autotools build system does not set OS_ defines #422

New Issue

claunia · 2026-01-29T20:43:36Z

claunia commented

2026-01-29 20:43:36 +00:00

Originally created by @ryandesign on GitHub (May 7, 2022).

The cmake build system sets some custom defines for various OS types in CMakeLists.txt

if(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
  add_definitions(-DOS_LINUX)
elseif(${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD")
  add_definitions(-DOS_FREEBSD)
elseif(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
  add_definitions(-DOS_MACOSX)
endif()

The undocumented autotools build system does not. Perhaps it should?

Originally created by @ryandesign on GitHub (May 7, 2022). The cmake build system sets some custom defines for various OS types in CMakeLists.txt ``` if(${CMAKE_SYSTEM_NAME} MATCHES "Linux") add_definitions(-DOS_LINUX) elseif(${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD") add_definitions(-DOS_FREEBSD) elseif(${CMAKE_SYSTEM_NAME} MATCHES "Darwin") add_definitions(-DOS_MACOSX) endif() ``` The undocumented autotools build system does not. Perhaps it should?

claunia added the release-v1.1.1 enhancement labels 2026-01-29 20:43:36 +00:00

claunia closed this issue

2026-01-29 20:43:36 +00:00

claunia commented

2026-01-29 20:43:37 +00:00

@eustas commented on GitHub (Jan 6, 2023):

TODO: add the following definitions to Bazel / naked make / autotools:

OS_LINUX
OS_FREEBSD
OS_MACOSX
BROTLI_HAVE_LOG2

@eustas commented on GitHub (Jan 6, 2023): TODO: add the following definitions to Bazel / naked make / autotools: - [x] `OS_LINUX` - [x] `OS_FREEBSD` - [x] `OS_MACOSX` - [x] `BROTLI_HAVE_LOG2`

claunia commented

2026-01-29 20:43:37 +00:00

@eustas commented on GitHub (Jul 10, 2023):

Only Bazel left.

@eustas commented on GitHub (Jul 10, 2023): Only Bazel left.

claunia referenced this issue

2026-01-29 20:52:12 +00:00

[PR #422] [MERGED] Fix typo in CMakeFile: s/BROTLI_BUNDLE_MODE/BROTLI_BUNDLED_MODE/ #1031

claunia referenced this issue

2026-01-29 20:52:13 +00:00

[PR #422] Fix typo in CMakeFile: s/BROTLI_BUNDLE_MODE/BROTLI_BUNDLED_MODE/ #1035

Sign in to join this conversation.