Add 3.11 wheels #438

@sans-c commented on GitHub (Oct 25, 2022):

Yep, right now brotli installation fails with Python 3.11 and pip with default options.

@sans-c commented on GitHub (Oct 25, 2022): Yep, right now brotli installation fails with Python 3.11 and pip with default options.

claunia commented

@mhils commented on GitHub (Oct 25, 2022):

It would be incredibly useful to provide abi3 wheels, which makes sure that no additional work is needed to support future Python releases: https://cibuildwheel.readthedocs.io/en/stable/faq/#abi3

@mhils commented on GitHub (Oct 25, 2022): It would be incredibly useful to provide `abi3` wheels, which makes sure that no additional work is needed to support future Python releases: https://cibuildwheel.readthedocs.io/en/stable/faq/#abi3

claunia commented

https://github.com/pypa/pip/issues/8559

@fenchu commented on GitHub (Nov 4, 2022):

Wheel installation will fix this deprecation on 3.11/pip23.1:

DEPRECATION: brotli is being installed using the legacy 'setup.py install' method, 
because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 
will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. 
Discussion can be found at https://github.com/pypa/pip/issues/8559

@fenchu commented on GitHub (Nov 4, 2022): Wheel installation will fix this deprecation on 3.11/pip23.1: ``` DEPRECATION: brotli is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559 ``` https://github.com/pypa/pip/issues/8559

claunia commented

@cherinyy commented on GitHub (Nov 8, 2022):

DEPRECATION: brotli is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed.

#987

@cherinyy commented on GitHub (Nov 8, 2022): > DEPRECATION: brotli is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. #987

claunia commented

@anthrotype commented on GitHub (Nov 15, 2022):

incredibly useful to provide abi3 wheels

indeed, but last time I tried this a couple years ago abi3 wheels would only work for linux or macos, but not for windows. I don't know if anything changed since then, would be worth retrying.

@anthrotype commented on GitHub (Nov 15, 2022): > incredibly useful to provide abi3 wheels indeed, but last time I tried this a couple years ago abi3 wheels would only work for linux or macos, but [not for windows](https://github.com/pypa/pip/issues/4445). I don't know if anything changed since then, would be worth retrying.

claunia commented

@anthrotype commented on GitHub (Nov 15, 2022):

note the brotli's wheels are built from this other repo https://github.com/google/brotli-wheels
it's probably just a matter of adding 3.11 to the build matrix and cibuildwheel should do the rest.
I'll take a look

@anthrotype commented on GitHub (Nov 15, 2022): note the brotli's wheels are built from this other repo https://github.com/google/brotli-wheels it's probably just a matter of adding 3.11 to the build matrix and cibuildwheel should do the rest. I'll take a look

claunia commented

@mhils commented on GitHub (Nov 15, 2022):

Anecdata: We've successfully shipped abi3 wheels for Windows, Linux and macOS about a month ago. It looks like everything works pretty flawlessly nowadays. 🙌

Here's an example conversion for aioquic I did a week ago: https://github.com/aiortc/aioquic/compare/main...mhils:aioquic:abi3
(CI: https://github.com/mhils/aioquic/actions/runs/3406468326)

@mhils commented on GitHub (Nov 15, 2022): Anecdata: We've successfully shipped abi3 wheels for Windows, Linux and macOS about a month ago. It looks like everything works pretty flawlessly nowadays. 🙌 Here's an example conversion for aioquic I did a week ago: https://github.com/aiortc/aioquic/compare/main...mhils:aioquic:abi3 (CI: https://github.com/mhils/aioquic/actions/runs/3406468326)

claunia commented

@alexprengere commented on GitHub (Nov 16, 2022):

I think this was closed by mistake @eustas.
#987 only fixes an issue reported as a comment here, not the original issue of the missing wheels (see here), which would need https://github.com/google/brotli-wheels/pull/15.

@alexprengere commented on GitHub (Nov 16, 2022): I think this was closed by mistake @eustas. #987 only fixes an issue reported as a comment here, not the original issue of the missing wheels (see [here](https://pypi.org/project/Brotli/#files)), which would need https://github.com/google/brotli-wheels/pull/15.

claunia commented

@eustas commented on GitHub (Nov 16, 2022):

Agree. That was auto-close because of "fix #xxx" in description

@eustas commented on GitHub (Nov 16, 2022): Agree. That was auto-close because of "fix #xxx" in description

claunia commented

@anthrotype commented on GitHub (Nov 16, 2022):

I built the python 3.11 wheels in https://github.com/google/brotli-wheels/pull/15 and can upload them manually using twine to PyPI, like I did for 3.10 wheels a year ago.
If @eustas cuts a new Brotli release, I can also update brotli-wheels repository to point to the latest git tag and new wheels can be built. Last tag was 2 years ago.

@anthrotype commented on GitHub (Nov 16, 2022): I built the python 3.11 wheels in https://github.com/google/brotli-wheels/pull/15 and can upload them manually using twine to PyPI, like I did for 3.10 wheels a year ago. If @eustas cuts a new Brotli release, I can also update brotli-wheels repository to point to the latest git tag and new wheels can be built. Last tag was 2 years ago.

claunia commented

@anthrotype commented on GitHub (Nov 16, 2022):

Regarding abi3 wheels I suggest you file a separate issue. I can't work on it right now, but found this interesting article https://blog.trailofbits.com/2022/11/15/python-wheels-abi-abi3audit/

@anthrotype commented on GitHub (Nov 16, 2022): Regarding abi3 wheels I suggest you file a separate issue. I can't work on it right now, but found this interesting article https://blog.trailofbits.com/2022/11/15/python-wheels-abi-abi3audit/

claunia commented

@anthrotype commented on GitHub (Nov 16, 2022):

I just uploaded the wheels for CPython 3.11 for linux, mac and windows at https://pypi.org/project/Brotli/1.0.9/#files so this can be closed

@anthrotype commented on GitHub (Nov 16, 2022): I just uploaded the wheels for CPython 3.11 for linux, mac and windows at https://pypi.org/project/Brotli/1.0.9/#files so this can be closed

claunia commented