Always_inline on GCC12 falis #451

New Issue

claunia · 2026-01-29T20:44:05Z

claunia commented

2026-01-29 20:44:05 +00:00

Originally created by @NikMikM on GitHub (Mar 22, 2023).

Hello! I am using GCC 12 (on Linux) and trying to make the library, but apparently, i have an error, which indicates that:

 inlining failed in call to ‘always_inline’ ‘SortHuffmanTree’: function not considered for inlining
  398 | static BROTLI_INLINE BROTLI_BOOL SortHuffmanTree(
      |                                  ^~~~~~~~~~~~~~~
In file included from brotli-1.0.9/c/enc/./brotli_bit_stream.h:23,
                 from brotli-1.0.9/c/enc/brotli_bit_stream.c:11:
brotli-1.0.9/c/enc/././entropy_encode.h:92:14: note: called from here
   92 |       while (comparator(&tmp, &items[j])) {
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
brotli-1.0.9/c/enc/brotli_bit_stream.c:398:34: error: inlining failed in call to ‘always_inline’ ‘SortHuffmanTree’: function not considered for inlining
  398 | static BROTLI_INLINE BROTLI_BOOL SortHuffmanTree(
      |                                  ^~~~~~~~~~~~~~~
brotli-1.0.9/c/enc/././entropy_encode.h:109:28: note: called from here
  109 |         for (; j >= gap && comparator(&tmp, &items[j - gap]); j -= gap) {

Could you please help me to solve it? I just can't understand exactly what's wrong.

Originally created by @NikMikM on GitHub (Mar 22, 2023). Hello! I am using GCC 12 (on Linux) and trying to make the library, but apparently, i have an error, which indicates that: ``` inlining failed in call to ‘always_inline’ ‘SortHuffmanTree’: function not considered for inlining 398 | static BROTLI_INLINE BROTLI_BOOL SortHuffmanTree( | ^~~~~~~~~~~~~~~ In file included from brotli-1.0.9/c/enc/./brotli_bit_stream.h:23, from brotli-1.0.9/c/enc/brotli_bit_stream.c:11: brotli-1.0.9/c/enc/././entropy_encode.h:92:14: note: called from here 92 | while (comparator(&tmp, &items[j])) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ brotli-1.0.9/c/enc/brotli_bit_stream.c:398:34: error: inlining failed in call to ‘always_inline’ ‘SortHuffmanTree’: function not considered for inlining 398 | static BROTLI_INLINE BROTLI_BOOL SortHuffmanTree( | ^~~~~~~~~~~~~~~ brotli-1.0.9/c/enc/././entropy_encode.h:109:28: note: called from here 109 | for (; j >= gap && comparator(&tmp, &items[j - gap]); j -= gap) { ``` Could you please help me to solve it? I just can't understand exactly what's wrong.

claunia closed this issue

2026-01-29 20:44:05 +00:00

claunia commented

2026-01-29 20:44:06 +00:00

@eustas commented on GitHub (Mar 22, 2023):

Hi. Going to check it there is an update in upstream macro library (headley), and rebase if any.
If it won't help, we should file an issue in the upstream.

@eustas commented on GitHub (Mar 22, 2023): Hi. Going to check it there is an update in upstream macro library (headley), and rebase if any. If it won't help, we should file an issue in the upstream.

claunia commented

2026-01-29 20:44:06 +00:00

@NikMikM commented on GitHub (Mar 22, 2023):

@eustas Sorry to bother you, i don't think that my issue is appropriate, since i've tried to use modified 'make'. I mean - it would be nice, if you just delete this issue, because i've downloaded the files from this repo and with GNU make it worked, and no such problem occured

@NikMikM commented on GitHub (Mar 22, 2023): @eustas Sorry to bother you, i don't think that my issue is appropriate, since i've tried to use modified 'make'. I mean - it would be nice, if you just delete this issue, because i've downloaded the files from this repo and with GNU make it worked, and no such problem occured

claunia referenced this issue

2026-01-29 20:52:23 +00:00

[PR #451] [MERGED] Fix "take output" flush workflow. #1073

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#451