EMPTY VERSION FIELDS IN PKGCONFIG FILES (LINUX) #472

New Issue

claunia · 2026-01-29T20:44:26Z

claunia commented

2026-01-29 20:44:26 +00:00

Originally created by @frkli1965 on GitHub (Jul 31, 2023).

Missing version values in libbrotlicommon.pc, libbrotlidec.pc and libbrotlienc.pc files following commit #27a9a80 causing downstream builds e.g. MPV, EasyEffects, etc. to break.

Easily remedied by manually editing above files of course but thought you should be made aware nevertheless.

Originally created by @frkli1965 on GitHub (Jul 31, 2023). Missing version values in libbrotlicommon.pc, libbrotlidec.pc and libbrotlienc.pc files following commit #27a9a80 causing downstream builds e.g. MPV, EasyEffects, etc. to break. Easily remedied by manually editing above files of course but thought you should be made aware nevertheless.

claunia closed this issue

2026-01-29 20:44:27 +00:00

claunia commented

2026-01-29 20:44:28 +00:00

@zhongfly commented on GitHub (Jul 31, 2023):

I think the submitter deleted this line by mistake: 27a9a80992 (diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL92) .

@zhongfly commented on GitHub (Jul 31, 2023): I think the submitter deleted this line by mistake: https://github.com/google/brotli/commit/27a9a80992e2308ef60bc6d840c8b59293c32d67#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL92 .

claunia commented

2026-01-29 20:44:28 +00:00

@balducci commented on GitHub (Jul 31, 2023):

am I missing something obvious, or commit d639a81d35 has deleted back the BROTLI_VERSION definition which was fixed by previous commit 802475e724089cbac50ca9eb8a198f7922d30971?

install:502> git diff 802475e724089cbac50ca9eb8a198f7922d30971 d639a81d35be28ffa281403384fb74e5242e2773  CMakeLists.txt
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 61378cd..bf5204d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -61,7 +61,6 @@ endfunction(read_macro)
 read_macro("c/common/version.h" "BROTLI_VERSION_MAJOR" BROTLI_VERSION_MAJOR)
 read_macro("c/common/version.h" "BROTLI_VERSION_MINOR" BROTLI_VERSION_MINOR)
 read_macro("c/common/version.h" "BROTLI_VERSION_PATCH" BROTLI_VERSION_PATCH)
-set(BROTLI_VERSION "${BROTLI_VERSION_MAJOR}.${BROTLI_VERSION_MINOR}.${BROTLI_VERSION_PATCH}")
 mark_as_advanced(BROTLI_VERSION BROTLI_VERSION_MAJOR BROTLI_VERSION_MINOR BROTLI_VERSION_PATCH)
 
 # ABI Version information

For me master (d639a81d35) still installs .pc files with empty Version: value

@balducci commented on GitHub (Jul 31, 2023): am I missing something obvious, or commit d639a81d35be28ffa281403384fb74e5242e2773 has deleted back the ``BROTLI_VERSION`` definition which was fixed by previous commit 802475e724089cbac50ca9eb8a198f7922d30971? ``` install:502> git diff 802475e724089cbac50ca9eb8a198f7922d30971 d639a81d35be28ffa281403384fb74e5242e2773 CMakeLists.txt diff --git a/CMakeLists.txt b/CMakeLists.txt index 61378cd..bf5204d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -61,7 +61,6 @@ endfunction(read_macro) read_macro("c/common/version.h" "BROTLI_VERSION_MAJOR" BROTLI_VERSION_MAJOR) read_macro("c/common/version.h" "BROTLI_VERSION_MINOR" BROTLI_VERSION_MINOR) read_macro("c/common/version.h" "BROTLI_VERSION_PATCH" BROTLI_VERSION_PATCH) -set(BROTLI_VERSION "${BROTLI_VERSION_MAJOR}.${BROTLI_VERSION_MINOR}.${BROTLI_VERSION_PATCH}") mark_as_advanced(BROTLI_VERSION BROTLI_VERSION_MAJOR BROTLI_VERSION_MINOR BROTLI_VERSION_PATCH) # ABI Version information ``` For me master (d639a81d35be28ffa281403384fb74e5242e2773) still installs .pc files with empty ``Version:`` value

claunia commented

2026-01-29 20:44:28 +00:00

@eustas commented on GitHub (Jul 31, 2023):

Sorry about that. Two way synchronisation is not properly setup... Will fix that very soon.

@eustas commented on GitHub (Jul 31, 2023): Sorry about that. Two way synchronisation is not properly setup... Will fix that very soon.

claunia commented

2026-01-29 20:44:28 +00:00

@balducci commented on GitHub (Aug 1, 2023):

confirming that everything is back on track

thanks a lot

-gabriele

@balducci commented on GitHub (Aug 1, 2023): confirming that everything is back on track thanks a lot -gabriele