[Feature Request] adding a option to control whether install the executable #485

Closed
opened 2026-01-29 20:44:41 +00:00 by claunia · 4 comments
Owner

Originally created by @leleliu008 on GitHub (Oct 6, 2023).

Hi, developers.
Could we add a option (like BROTLI_INSTALL_EXE) to control whether install the executable? I only need a shared library and a static library, I don't need the exectuable. I'm a package manager, I do not use this project as a sub project.

Originally created by @leleliu008 on GitHub (Oct 6, 2023). Hi, developers. Could we add a option (like `BROTLI_INSTALL_EXE`) to control whether install the executable? I only need a shared library and a static library, I don't need the exectuable. I'm a package manager, I do not use this project as a sub project.
Author
Owner

@eustas commented on GitHub (Oct 18, 2023):

Sure, why not. Will try to add it soon.

@eustas commented on GitHub (Oct 18, 2023): Sure, why not. Will try to add it soon.
Author
Owner

@timlegge commented on GitHub (Nov 2, 2023):

@eustas in particular could the option not build the executable at all. I am maintaining the perl module that links teh libraries. However, brotli.c uses fopen_s and sopen_s and older versions of gcc on windows do not support those functions.

However linking the libraries and testing the perl module works fine if I remove the build of the executable and the applicable tests from the CMakeLists.txt file

@timlegge commented on GitHub (Nov 2, 2023): @eustas in particular could the option not build the executable at all. I am maintaining the perl module that links teh libraries. However, brotli.c uses fopen_s and sopen_s and older versions of gcc on windows do not support those functions. However linking the libraries and testing the perl module works fine if I remove the build of the executable and the applicable tests from the CMakeLists.txt file
Author
Owner

@eustas commented on GitHub (Nov 27, 2023):

Should be fixed by #1098

@eustas commented on GitHub (Nov 27, 2023): Should be fixed by #1098
Author
Owner

@leleliu008 commented on GitHub (Nov 27, 2023):

@eustas Thanks, I will try it when next release is published.

@leleliu008 commented on GitHub (Nov 27, 2023): @eustas Thanks, I will try it when next release is published.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#485