request: concerning building and installing brunsli with google-test (gtest) #517

New Issue

claunia · 2026-01-29T20:45:07Z

claunia commented

2026-01-29 20:45:07 +00:00

Originally created by @Corin-EU on GitHub (Aug 29, 2024).

This behavior is with brunsli latest source code r.cbbc39a

The CMake procedure should do a test to see if google-test is already installed on the system and is at least the minimum version required and use that instead of the source in contrib/gtest.

At the very least (if the above is too onerous) there should be a CMake flag ENABLE_SYSTEM_GTEST to allow the system installed version to be used instead of the version contained in contrib/gtest.

And most importantly, the install procedure should not attempt to install the google-test component if the google-test is already installed on the system otherwise the following will occur for those who manage "local" installed software with stow

         /usr/local/bin/stow -d "/usr/local/stow/Graphics/Libraries" -t "/usr/local" "brunsli-r.cbbc39a"
         WARNING! stowing brunsli-r.cbbc39a would cause conflicts:
         * existing target is stowed to a different package: include/gtest/gtest-death-test.h =>
           ../../stow/Development/Libraries/googletest-1.15.2/include/gtest/gtest-death-test.h
         ... [etc, etc, etc for all the other googletest files] ...

Thank you!

SORRY this should have been posted in "brunsli" not "brotli".

Originally created by @Corin-EU on GitHub (Aug 29, 2024). This behavior is with brunsli latest source code r.cbbc39a The CMake procedure should do a test to see if google-test is already installed on the system and is at least the minimum version required and use that instead of the source in contrib/gtest. At the very least (if the above is too onerous) there should be a CMake flag ENABLE_SYSTEM_GTEST to allow the system installed version to be used instead of the version contained in contrib/gtest. And most importantly, the install procedure should not attempt to install the google-test component if the google-test is already installed on the system otherwise the following will occur for those who manage "local" installed software with stow /usr/local/bin/stow -d "/usr/local/stow/Graphics/Libraries" -t "/usr/local" "brunsli-r.cbbc39a" WARNING! stowing brunsli-r.cbbc39a would cause conflicts: * existing target is stowed to a different package: include/gtest/gtest-death-test.h => ../../stow/Development/Libraries/googletest-1.15.2/include/gtest/gtest-death-test.h ... [etc, etc, etc for all the other googletest files] ... Thank you! SORRY this should have been posted in "brunsli" not "brotli".

claunia closed this issue

2026-01-29 20:45:07 +00:00

claunia commented

2026-01-29 20:45:07 +00:00

@Corin-EU commented on GitHub (Aug 29, 2024):

Filed under wrong project.

@Corin-EU commented on GitHub (Aug 29, 2024): Filed under wrong project.

claunia referenced this issue

2026-01-29 20:52:44 +00:00

[PR #517] Move `java/` to `java/org/brotli/` to fix `sources.jar` structure #1156

Sign in to join this conversation.