starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-09-22 14:45:51 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

Create tags for the Go module #537

New Issue
Closed
opened 2026-01-29 20:45:22 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 20:45:22 +00:00
Owner
Copy Link

Originally created by @dunglas on GitHub (Apr 23, 2025).

Currently, the Go module you provide has no stable version: https://pkg.go.dev/github.com/google/brotli/go/cbrotli

This is because, to create Go module versions for packages not at the root of the Git repository, Git tags must follow a special convention: https://go.dev/wiki/Modules#publishing-a-release

Creating these tags (for instance go/cbrotli/v1.1.0 for ed738e842d) would be convenient, it will prevent using development versions for the Go module not compatible with the stable version of the C library shipped by distributions.

This may likely be automated.

Thanks.

Originally created by @dunglas on GitHub (Apr 23, 2025). Currently, the Go module you provide has no stable version: https://pkg.go.dev/github.com/google/brotli/go/cbrotli This is because, to create Go module versions for packages not at the root of the Git repository, Git tags must follow a special convention: https://go.dev/wiki/Modules#publishing-a-release Creating these tags (for instance `go/cbrotli/v1.1.0` for ed738e842d2fbdf2d6459e39267a633c4a9b2f5d) would be convenient, it will prevent using development versions for the Go module not compatible with the stable version of the C library shipped by distributions. This may likely be automated. Thanks.
claunia commented 2026-01-29 20:45:22 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (May 27, 2025):

Sure, thanks for the heads-up. Will do soon.

@eustas commented on GitHub (May 27, 2025): Sure, thanks for the heads-up. Will do soon.
claunia commented 2026-01-29 20:45:22 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (May 27, 2025):

Done. Could you check it works?

@eustas commented on GitHub (May 27, 2025): Done. Could you check it works?
claunia commented 2026-01-29 20:45:23 +00:00
Author
Owner
Copy Link

@dunglas commented on GitHub (May 27, 2025):

This works: https://github.com/dunglas/caddy-cbrotli/pull/5! Thank you very much.

@dunglas commented on GitHub (May 27, 2025): This works: https://github.com/dunglas/caddy-cbrotli/pull/5! Thank you very much.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#537
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?