starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-09-22 06:35:52 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

Publish brotli_go to the Bazel Central Registry #541

New Issue
Closed
opened 2026-01-29 20:45:25 +00:00 by claunia · 5 comments
claunia commented 2026-01-29 20:45:25 +00:00
Owner
Copy Link

Originally created by @sbarfurth on GitHub (May 30, 2025).

The go folder has a handy MODULE.bazel file, but the specified brotli_go module isn't published to the BCR. This makes usage annoying and requires a git_override. It seems relatively straightforward to publish this module to the BCR for a maintainer.

As a side note:

We need to use the Bazel module because using the Go module with Gazelle doesn't work for Brotli. The auto-generated target @com_github_google_brotli_go_cbrotli//:cbrotli will fail to build.

No repository visible as '@org_brotli' from repository '@@gazelle++go_deps+com_github_google_brotli_go_cbrotli' and referenced by '@@gazelle++go_deps+com_github_google_brotli_go_cbrotli//:cbrotli'

This happens even when there is a bazel_dep with the correct repository name for brotli from the BCR.

Originally created by @sbarfurth on GitHub (May 30, 2025). The `go` folder has a handy `MODULE.bazel` file, but the specified `brotli_go` module isn't published to the BCR. This makes usage annoying and requires a `git_override`. It seems relatively straightforward to publish this module to the BCR for a maintainer. As a side note: We need to use the Bazel module because using the Go module with Gazelle doesn't work for Brotli. The auto-generated target `@com_github_google_brotli_go_cbrotli//:cbrotli` will fail to build. > `No repository visible as '@org_brotli' from repository '@@gazelle++go_deps+com_github_google_brotli_go_cbrotli' and referenced by '@@gazelle++go_deps+com_github_google_brotli_go_cbrotli//:cbrotli'` This happens even when there is a `bazel_dep` with the correct repository name for `brotli` from the BCR.
claunia commented 2026-01-29 20:45:26 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (May 30, 2025):

Sure, will do that soon.

@eustas commented on GitHub (May 30, 2025): Sure, will do that soon.
claunia commented 2026-01-29 20:45:26 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (May 30, 2025):

I think it will be three stage thing, though:

  • publish v1.1.0-adhoc (since 1.1.0 tag does not contain MODULE.bazel)
  • release brotli v1.2.0 (hopefully soon)
  • publish v1.2.0
@eustas commented on GitHub (May 30, 2025): I think it will be three stage thing, though: - publish v1.1.0-adhoc (since 1.1.0 tag does not contain MODULE.bazel) - release brotli v1.2.0 (hopefully soon) - publish v1.2.0
claunia commented 2026-01-29 20:45:26 +00:00
Author
Owner
Copy Link

@sbarfurth commented on GitHub (May 30, 2025):

Sounds great, thanks @eustas. Happy to help if needed.

@sbarfurth commented on GitHub (May 30, 2025): Sounds great, thanks @eustas. Happy to help if needed.
claunia commented 2026-01-29 20:45:26 +00:00
Author
Owner
Copy Link

@sbarfurth commented on GitHub (Jun 2, 2025):

For tracking: bazelbuild/bazel-central-registry#4734

@sbarfurth commented on GitHub (Jun 2, 2025): For tracking: bazelbuild/bazel-central-registry#4734
claunia commented 2026-01-29 20:45:27 +00:00
Author
Owner
Copy Link

@sbarfurth commented on GitHub (Jun 19, 2025):

The PR was merged. Thanks @eustas! We can now depend on the Brotli Golang from the BCR.

@sbarfurth commented on GitHub (Jun 19, 2025): The PR was merged. Thanks @eustas! We can now depend on the Brotli Golang from the BCR.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#541
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?