mirror of
https://github.com/google/brotli.git
synced 2026-07-08 17:56:58 +00:00
I want to compile a riscv-edk2-master but the latest version is not fit #542
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @LunaticLegacy on GitHub (May 27, 2025).
So I have a question: WHICH VERSION's brotli should I fetch for the missing symbols?
@LunaticLegacy commented on GitHub (May 27, 2025):
The latest version has no "dictionary.c" but "dictionary_hash.c".
@eustas commented on GitHub (May 27, 2025):
I believe it is not about version, but about symbol visibility.
It seems that between compilation and linking of brotli it has been stripped. Or compiler was somewhat too aggressive.
Try compiling with
-DBROTLI_INTERNAL=. That will disable some symbol hiding.@LunaticLegacy commented on GitHub (May 27, 2025):
It's useless. Once I'm compiling edk2, the symbols above were hidden. But after I added
CFLAGS += -DBROTLI_INTERNAL=into${edk2_dir}/BaseTools/Source/C/BrotilCompress/Makefile, the same problem happened again.So which MakeFile should I edit?
@eustas commented on GitHub (May 27, 2025):
Let's debug bottom-up. First try adding
#define BROTLI_INTERNALinc/include/brotli /port.habove line 242. Then clean-build.@LunaticLegacy commented on GitHub (May 27, 2025):
I did. I just modified that file, then
make cleanandmakeagain.But same problem happened, again.
@LunaticLegacy commented on GitHub (May 27, 2025):
Also, here's the directory I run
make:@eustas commented on GitHub (May 27, 2025):
Is the thing you are trying to build on github, so I could try myself?
@LunaticLegacy commented on GitHub (May 27, 2025):
Yes. I want to compile an essential UEFI for QEMU Windows for RISC-V. Because the iso file i have should be loaded via UEFI to install.
@eustas commented on GitHub (May 27, 2025):
This one: https://github.com/riscvarchive/riscv-edk2-platforms/blob/master/Platform/RISC-V/PlatformPkg/Readme.md ?
@LunaticLegacy commented on GitHub (May 27, 2025):
idk, but I downloaded the source via:
https://github.com/riscvarchive/riscv-edk2-platforms/tree/master
@LunaticLegacy commented on GitHub (May 29, 2025):
Problem fixed after I modified GNUMakefile via
D:\Git\riscv-edk2-master\BaseTools\Source\C\BrotliCompress.