starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-09-22 22:56:08 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

Unnecessary loop in BrotliWarmupBitReader #548

New Issue
Closed
opened 2026-01-29 20:45:32 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 20:45:32 +00:00
Owner
Copy Link

Originally created by @vax-r on GitHub (Sep 6, 2025).

Description

98a89b1563/c/dec/bit_reader.c (L49)

In the code section mentioned above, no matter the return is exectued within loop or not, it's going to return BROTLI_TRUE . Maybe we can consider remove the loop cause eventually it's going to be a BROTLI_TRUE.

I would like to send a PR if that's the case, or we do have special concerns at this point so the loop is a must ?

Originally created by @vax-r on GitHub (Sep 6, 2025). ## Description https://github.com/google/brotli/blob/98a89b1563c728c351c4d8b0b6390cadb9fa0391/c/dec/bit_reader.c#L49 In the code section mentioned above, no matter the return is exectued within loop or not, it's going to return `BROTLI_TRUE` . Maybe we can consider remove the loop cause eventually it's going to be a `BROTLI_TRUE`. I would like to send a PR if that's the case, or we do have special concerns at this point so the loop is a must ?
claunia commented 2026-01-29 20:45:33 +00:00
Author
Owner
Copy Link

@eustas commented on GitHub (Sep 10, 2025):

Loop is not unnecessary - it improves performance for some platforms. See comments around aligned_read_mask and BROTLI_UNALIGNED_READ_FAST.

@eustas commented on GitHub (Sep 10, 2025): Loop is not unnecessary - it improves performance for some platforms. See comments around `aligned_read_mask` and `BROTLI_UNALIGNED_READ_FAST`.
claunia commented 2026-01-29 20:45:33 +00:00
Author
Owner
Copy Link

@vax-r commented on GitHub (Sep 16, 2025):

Loop is not unnecessary - it improves performance for some platforms. See comments around aligned_read_mask and BROTLI_UNALIGNED_READ_FAST.

I see, thank you !

@vax-r commented on GitHub (Sep 16, 2025): > Loop is not unnecessary - it improves performance for some platforms. See comments around `aligned_read_mask` and `BROTLI_UNALIGNED_READ_FAST`. I see, thank you !
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#548
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?