[PR #33] [MERGED] Fix encoder compilation error on MSVS 2010. #612

New Issue

claunia · 2026-01-29T20:46:25Z

claunia commented

2026-01-29 20:46:25 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/33
Author: @szabadka
Created: 2/27/2015
Status: ✅ Merged
Merged: 2/27/2015
Merged by: @szabadka

Base: master ← Head: master

📝 Commits (1)

fab601e Fix encoder compilation error on MSVS 2010.

📊 Changes

2 files changed (+10 additions, -2 deletions)

View changed files

📝 enc/fast_log.h (+7 -0)
📝 enc/literal_cost.cc (+3 -2)

📄 Description

As reported by @anthrotype, log2() is missing from MSVS 2010.
This patch uses log() and a multiplication in FastLog2()
for _MSV_VER <= 1600 and uses FastLog2() in literal_cost.cc
instead of log2().

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/33 **Author:** [@szabadka](https://github.com/szabadka) **Created:** 2/27/2015 **Status:** ✅ Merged **Merged:** 2/27/2015 **Merged by:** [@szabadka](https://github.com/szabadka) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`fab601e`](https://github.com/google/brotli/commit/fab601e81fd464342d7c31736a5bc7ad413bce63) Fix encoder compilation error on MSVS 2010. ### 📊 Changes **2 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `enc/fast_log.h` (+7 -0) 📝 `enc/literal_cost.cc` (+3 -2) </details> ### 📄 Description As reported by @anthrotype, log2() is missing from MSVS 2010. This patch uses log() and a multiplication in FastLog2() for _MSV_VER <= 1600 and uses FastLog2() in literal_cost.cc instead of log2(). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:46:25 +00:00

claunia referenced this issue

2026-01-29 20:53:13 +00:00

[PR #612] [MERGED] Use bazel in appveyor #1262

claunia referenced this issue

2026-01-29 20:53:16 +00:00

[PR #621] [MERGED] Pick-up 1.0.2 changes #1270

claunia referenced this issue

2026-01-29 20:53:23 +00:00

[PR #644] [CLOSED] Pickup v1.0.3 changes #1293

Sign in to join this conversation.