mirror of
https://github.com/google/brotli.git
synced 2026-07-08 17:56:58 +00:00
[PR #32] further fixes to allow compilation on MS Visual Studio 2010 #613
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/google/brotli/pull/32
State: closed
Merged: No
Hello,
I don't like playing the Windows guy here, but there are still some unresolved issues with Microsoft's C++ compiler.
The recent patches by @szabadka ensured the Brotli encoder compiles successfully when using MS Visual Studio 2013.
However, the problem is that the latest Python for Windows (versions 3.3 and 3.4) are compiled with Visual Studio 2010.
Now, from what I understood, there's a requirement that Python extensions be linked to the same C runtime library which Python itself uses:
https://docs.python.org/3.4/extending/windows.html
If that's the case, then we must define a
log2(binary logarithm) function, which unfortunately is not present inmath.hfrom Visual C++ 2010.Here's my attempt, which seemingly doesn't break anything else, since I only redefine log2 if
_MSC_VER <= 1600.Through this patch, the Python extension can be built on Windows using the same compiler version used to build CPython itself.
Well, at least for Python 3.3 and 3.4... previous versions are still built with Visual Studio 2008, but I still had no luck with that.
Cheers,
C.