[PR #37] [MERGED] [python] setup.py fixes for Windows #620

New Issue

claunia · 2026-01-29T20:46:27Z

claunia commented

2026-01-29 20:46:27 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/37
Author: @anthrotype
Created: 3/16/2015
Status: ✅ Merged
Merged: 3/16/2015
Merged by: @szabadka

Base: master ← Head: setup_py

📝 Commits (3)

855efcf [python/setup.py] use relative paths instead of symlinks (unsupported on Win)
dec72c5 [setup.py] use "-std=c++0x" only with GCC compiler (usupported on MSVC)
3113fe7 [setup.py] enable C++ exception handling on MSVC compiler to fix warning C4530

📊 Changes

4 files changed (+51 additions, -49 deletions)

View changed files

📝 python/brotlimodule.cc (+2 -2)
➖ python/dec (+0 -1)
➖ python/enc (+0 -1)
📝 python/setup.py (+49 -45)

📄 Description

I split my previous pull request #31 into two smaller one.
this one includes changes to setup.py to allow the building of the Python extension on Windows, which does not like UNIX-style symlinks, and does not understand gcc-specific compiler flags.
Sorry for multiple posting.
Thanks.

C.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/37 **Author:** [@anthrotype](https://github.com/anthrotype) **Created:** 3/16/2015 **Status:** ✅ Merged **Merged:** 3/16/2015 **Merged by:** [@szabadka](https://github.com/szabadka) **Base:** `master` ← **Head:** `setup_py` --- ### 📝 Commits (3) - [`855efcf`](https://github.com/google/brotli/commit/855efcf75cf8f6854262022662871c95adb036e9) [python/setup.py] use relative paths instead of symlinks (unsupported on Win) - [`dec72c5`](https://github.com/google/brotli/commit/dec72c5931d4208c95f7cc1ee55a7a347e76b54d) [setup.py] use "-std=c++0x" only with GCC compiler (usupported on MSVC) - [`3113fe7`](https://github.com/google/brotli/commit/3113fe716385a1a5e3a8be1a7a673ddbdc46cfac) [setup.py] enable C++ exception handling on MSVC compiler to fix warning C4530 ### 📊 Changes **4 files changed** (+51 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `python/brotlimodule.cc` (+2 -2) ➖ `python/dec` (+0 -1) ➖ `python/enc` (+0 -1) 📝 `python/setup.py` (+49 -45) </details> ### 📄 Description I split my previous pull request #31 into two smaller one. this one includes changes to setup.py to allow the building of the Python extension on Windows, which does not like UNIX-style symlinks, and does not understand gcc-specific compiler flags. Sorry for multiple posting. Thanks. C. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:46:27 +00:00

claunia referenced this issue

2026-01-29 20:53:15 +00:00

[PR #620] [MERGED] Add autotools build #1266

claunia referenced this issue

2026-01-29 20:53:16 +00:00

[PR #621] [MERGED] Pick-up 1.0.2 changes #1270

claunia referenced this issue

2026-01-29 20:53:23 +00:00

[PR #644] [CLOSED] Pickup v1.0.3 changes #1293

Sign in to join this conversation.