[PR #65] [CLOSED] Clean up some warnings in header files. #654

New Issue

claunia · 2026-01-29T20:48:03Z

claunia commented

2026-01-29 20:48:03 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/65
Author: @nemequ
Created: 4/3/2015
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

cbd31f3 Clean up some warnings in header files.

📊 Changes

3 files changed (+7 additions, -7 deletions)

View changed files

📝 enc/hash.h (+4 -4)
📝 enc/ringbuffer.h (+1 -1)
📝 enc/static_dict.h (+2 -2)

📄 Description

These warnings are triggered when compiling with -Wshadow or
-Wsign-compare. Since they are in header files they will also be
triggered in any project attempting to use brotli while compiling
with those warnings enabled.

For an example of these being triggered in an external project, see https://travis-ci.org/quixdb/squash/jobs/56952895#L790

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/65 **Author:** [@nemequ](https://github.com/nemequ) **Created:** 4/3/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`cbd31f3`](https://github.com/google/brotli/commit/cbd31f3d54c2d3d960a017bf498f964eaf9a2dc0) Clean up some warnings in header files. ### 📊 Changes **3 files changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `enc/hash.h` (+4 -4) 📝 `enc/ringbuffer.h` (+1 -1) 📝 `enc/static_dict.h` (+2 -2) </details> ### 📄 Description These warnings are triggered when compiling with -Wshadow or -Wsign-compare. Since they are in header files they will also be triggered in any project attempting to use brotli while compiling with those warnings enabled. For an example of these being triggered in an external project, see https://travis-ci.org/quixdb/squash/jobs/56952895#L790 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:48:03 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#654