starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-07-08 17:56:58 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

[PR #65] Clean up some warnings in header files. #659

New Issue
Closed
opened 2026-01-29 20:48:03 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 20:48:03 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/google/brotli/pull/65

State: closed
Merged: No

These warnings are triggered when compiling with -Wshadow or
-Wsign-compare. Since they are in header files they will also be
triggered in any project attempting to use brotli while compiling
with those warnings enabled.

For an example of these being triggered in an external project, see https://travis-ci.org/quixdb/squash/jobs/56952895#L790

**Original Pull Request:** https://github.com/google/brotli/pull/65 **State:** closed **Merged:** No --- These warnings are triggered when compiling with -Wshadow or -Wsign-compare. Since they are in header files they will also be triggered in any project attempting to use brotli while compiling with those warnings enabled. For an example of these being triggered in an external project, see https://travis-ci.org/quixdb/squash/jobs/56952895#L790
claunia added the pull-request label 2026-01-29 20:48:03 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#659
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?