[PR #119] [MERGED] Deprecate greedy_block_split and enable_context_modeling brotli params. #730

Closed
opened 2026-01-29 20:50:35 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/119
Author: @szabadka
Created: 6/12/2015
Status: Merged
Merged: 6/12/2015
Merged by: @szabadka

Base: masterHead: master


📝 Commits (1)

  • 618287b Deprecate greedy_block_split and enable_context_modeling brotli params.

📊 Changes

8 files changed (+32 additions, -89 deletions)

View changed files

📝 enc/backward_references.cc (+15 -26)
📝 enc/backward_references.h (+0 -1)
📝 enc/cluster.h (+0 -16)
📝 enc/encode.cc (+2 -9)
📝 enc/encode.h (+2 -1)
📝 enc/encode_parallel.cc (+1 -4)
📝 enc/metablock.cc (+12 -31)
📝 enc/metablock.h (+0 -1)

📄 Description

These affected only quality 11, and now it does not make sense
to disable block splitting or context modeling because most of
the time is spent in zopfli anyway.

Now all speed vs size compromises are controlled by the quality param.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/119 **Author:** [@szabadka](https://github.com/szabadka) **Created:** 6/12/2015 **Status:** ✅ Merged **Merged:** 6/12/2015 **Merged by:** [@szabadka](https://github.com/szabadka) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`618287b`](https://github.com/google/brotli/commit/618287b3734816a2e86bfc2a7e3922fee944b521) Deprecate greedy_block_split and enable_context_modeling brotli params. ### 📊 Changes **8 files changed** (+32 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `enc/backward_references.cc` (+15 -26) 📝 `enc/backward_references.h` (+0 -1) 📝 `enc/cluster.h` (+0 -16) 📝 `enc/encode.cc` (+2 -9) 📝 `enc/encode.h` (+2 -1) 📝 `enc/encode_parallel.cc` (+1 -4) 📝 `enc/metablock.cc` (+12 -31) 📝 `enc/metablock.h` (+0 -1) </details> ### 📄 Description These affected only quality 11, and now it does not make sense to disable block splitting or context modeling because most of the time is spent in zopfli anyway. Now all speed vs size compromises are controlled by the quality param. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 20:50:35 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#730