[PR #124] [MERGED] Fix encoder bug. #736

New Issue

claunia · 2026-01-29T20:50:37Z

claunia commented

2026-01-29 20:50:37 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/124
Author: @szabadka
Created: 7/30/2015
Status: ✅ Merged
Merged: 7/30/2015
Merged by: @szabadka

Base: master ← Head: master

📝 Commits (1)

29c2679 Fix encoder bug.

📊 Changes

3 files changed (+24 additions, -6 deletions)

View changed files

📝 enc/block_splitter.cc (+19 -5)
📝 enc/block_splitter.h (+4 -0)
📝 enc/metablock.cc (+1 -1)

📄 Description

Under some circumstances CopyLiteralsToByteArray tried
to read begind ringbuffer.

In this patch we force it to read completely from range [0..mask]

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/124 **Author:** [@szabadka](https://github.com/szabadka) **Created:** 7/30/2015 **Status:** ✅ Merged **Merged:** 7/30/2015 **Merged by:** [@szabadka](https://github.com/szabadka) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`29c2679`](https://github.com/google/brotli/commit/29c2679500594832e4a1b30ad247db1a43233f74) Fix encoder bug. ### 📊 Changes **3 files changed** (+24 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `enc/block_splitter.cc` (+19 -5) 📝 `enc/block_splitter.h` (+4 -0) 📝 `enc/metablock.cc` (+1 -1) </details> ### 📄 Description Under some circumstances CopyLiteralsToByteArray tried to read begind ringbuffer. In this patch we force it to read completely from range [0..mask] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:50:37 +00:00

claunia closed this issue

2026-01-29 20:50:37 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#736