[PR #134] fix RuntimeError by terminating kwlist with NULL pointer #749

New Issue

claunia · 2026-01-29T20:50:40Z

claunia commented

2026-01-29 20:50:40 +00:00

Original Pull Request: https://github.com/google/brotli/pull/134

State: closed
Merged: No

The <malloc.h> header is non-standard, and causes compilation error on OS X:

dec/decode.c:16:10: fatal error: 'malloc.h' file not found
#include <malloc.h>
         ^
1 error generated.
error: command 'clang' failed with exit status 1

Just including <stdlib.h> should be sufficient in this case.

I also realised that I broke the brotli.compress function in #131... at least on OS X, running the tests raises:

RuntimeError: More keyword list entries (10) than format specifiers (5)

That's because I forgot to terminate the kwlist array with NULL pointer.
Sorry about that.

Strangely enough this error doesn't occur on Windows.

That's one more reason to have continuous integration systems like Travis/Appveyor running tests on multiple platforms. As a bonus, we could have them automatically build Python wheels for both Win and Mac, and deploying them to Github Releases every time a new release is tagged.
I'll send a specific PR for that soon.

**Original Pull Request:** https://github.com/google/brotli/pull/134 **State:** closed **Merged:** No --- The `<malloc.h>` header is non-standard, and causes compilation error on OS X: ``` dec/decode.c:16:10: fatal error: 'malloc.h' file not found #include <malloc.h> ^ 1 error generated. error: command 'clang' failed with exit status 1 ``` Just including `<stdlib.h>` should be sufficient in this case. I also realised that I broke the `brotli.compress` function in #131... at least on OS X, running the tests raises: ``` RuntimeError: More keyword list entries (10) than format specifiers (5) ``` That's because I forgot to terminate the `kwlist` array with `NULL` pointer. Sorry about that. Strangely enough this error doesn't occur on Windows. That's one more reason to have continuous integration systems like Travis/Appveyor running tests on multiple platforms. As a bonus, we could have them automatically build Python wheels for both Win and Mac, and deploying them to Github Releases every time a new release is tagged. I'll send a specific PR for that soon.

claunia added the pull-request label 2026-01-29 20:50:40 +00:00

claunia closed this issue

2026-01-29 20:50:40 +00:00

claunia referenced this issue

2026-01-29 20:53:46 +00:00

[PR #737] [CLOSED] Remove unnecessary var init #1373

claunia referenced this issue

2026-01-29 20:53:47 +00:00

[PR #749] [MERGED] Update #1378

claunia referenced this issue

2026-01-29 20:53:48 +00:00

[PR #749] Update #1383