mirror of
https://github.com/google/brotli.git
synced 2026-07-09 02:08:06 +00:00
Rename bro cmdline program to brotli (or similar) #76
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @thinred on GitHub (Dec 18, 2015).
Hi,
I'm packaging brotli for Debian and I wanted to install bro.py in /usr/bin.
I wanted to know what would be the official name for this program and rename it if it conflicts:
According to the above, I'd be happy if you would rename bro.py to brotli or something else that does not conflict, nor violates Debian policy.
Best regards,
Tomasz
@anthrotype commented on GitHub (Dec 18, 2015):
Hi @thinred,
The reason I did the
bro.pyscript was primarily to test the Brotli Python extension on Windows (cf. https://github.com/google/brotli/pull/38).At that time, I wasn't able to compile the
bro.cctool for Windows, and I wanted to avoid having to install Cygwin, MSYS, etc., in order to run thecompatibility_test.shandroundtrip_test.shscripts. So I wrote a Python clone of thebro.cctool and equivalent scripts for compatibility and roundtrip tests.I didn't add
bro.pyto thebrotliPython package, nor thesetup.pyscript, because I thought that users of the Python bindings would be more interested in usingbrotlias a module to import in other applications, rather than as a command line script.However, if you or others think it could be useful, we could easily move it inside the package and have
setuptoolsgenerate a platform-specific console script (using itsentry_pointsfeature). On Linux or OS X, it would be named without the.pyextension, whereas on Windows it will have.exe.Although, I guess for Debian it would be fine to simply package the C++ command line tool (that is called
browith no language extensions).Also, bear in mind, the Python bindings and hence
bro.pystill don't expose the new streaming API, while thebroC++ tool does (cf. https://github.com/google/brotli/pull/271).@thinred commented on GitHub (Dec 18, 2015):
Hi @anthrotype,
thank you for your elaborate response. I must admit that I missed bro.cc in the sources :).
Ok, I prefer bro.cc too, but the naming issue remains. I think that it must be installed as /usr/bin/brotli and not /usr/bin/bro...
Another problem that may deserve its own issue is that brotli has no dynamic library. Do you plan to provide libbrotli?
@nemequ commented on GitHub (Dec 21, 2015):
I could be wrong, but I don't think brotli is API/ABI stable yet; it might be wise to hold off on packaging a library for now.
@thinred commented on GitHub (Dec 21, 2015):
That's what I thought, fair enough.
What about the name of cmdline program?
@catlee commented on GitHub (Jan 19, 2016):
would be great if the CLI followed standard patterns like gzip, bzip2 and xz use.
@eustas commented on GitHub (Jun 1, 2017):
Fixed in #555.