Undefined behaviour in python .cc module? #82

New Issue

claunia · 2026-01-29T20:32:11Z

claunia commented

2026-01-29 20:32:11 +00:00

Originally created by @mmastrac on GitHub (Dec 26, 2015).

When compiling on OSX, I get this:

python/brotlimodule.cc:131:12: warning: comparison of constant -1 with expression of type 'BrotliParams::Mode' is always true
      [-Wtautological-constant-out-of-range-compare]

I suspect the cast of the out-of-range -1 to an enum is undefined behaviour in C++, but I'm not certain.

Originally created by @mmastrac on GitHub (Dec 26, 2015). When compiling on OSX, I get this: ``` python/brotlimodule.cc:131:12: warning: comparison of constant -1 with expression of type 'BrotliParams::Mode' is always true [-Wtautological-constant-out-of-range-compare] ``` I suspect the cast of the out-of-range -1 to an enum is undefined behaviour in C++, but I'm not certain.

claunia closed this issue

2026-01-29 20:32:12 +00:00

claunia commented

2026-01-29 20:32:13 +00:00

@anthrotype commented on GitHub (Dec 26, 2015):

cc @khaledhosny

@anthrotype commented on GitHub (Dec 26, 2015): cc @khaledhosny

claunia commented

2026-01-29 20:32:14 +00:00

@eustas commented on GitHub (Jan 18, 2016):

Hello, Matt.

Thank you for your report. Could you check if casting mote to int in python/brotlimodule.cc:131 fixes the problem?

Best regards,
Eugene.

@eustas commented on GitHub (Jan 18, 2016): Hello, Matt. Thank you for your report. Could you check if casting mote to int in python/brotlimodule.cc:131 fixes the problem? Best regards, Eugene.

claunia referenced this issue

2026-01-29 20:50:19 +00:00

[PR #82] [MERGED] Add input and output classes for streaming compression. #681

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#82