[PR #231] [MERGED] Use consistent bit ordering and variable names #823

New Issue

claunia · 2026-01-29T20:51:06Z

claunia commented

2026-01-29 20:51:06 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/231
Author: @dsnet
Created: 10/20/2015
Status: ✅ Merged
Merged: 10/26/2015
Merged by: @szabadka

Base: master ← Head: master

📝 Commits (4)

c996c06 Use consistent bit ordering and variable names
efeb59c Placed explicit bit pattern table for MNIBBLES to avoid any doubts
0a9f65a s/static prefix code/variable length code/g
ec8756d Remove note at end of section 3.1 about switching prefix conventions

📊 Changes

1 file changed (+30 additions, -23 deletions)

View changed files

📝 docs/draft-alakuijala-brotli-07.nroff (+30 -23)

📄 Description

If bits are to be parsed from left-to-right, then make the bit-strings left-justified.
If bits are to be parsed from right-to-left, then make the bit-strings right-justified.

Section 3.1, which describes how prefix codes work shows prefix codes that are "left-to-right", which
is better for demonstrating how the work. However, most of the rest of the document uses a "right-to-left"
convention. We should distinctly say at the end of section 3.1 that we are switching conventions.

Thus, change the prefix code in section 3.5 to be "right-to-left" to be consistent with sections 9.1
and 9.2.

Also, change the variable names in section 7.3 to be consistent with those used in section 10.

Also, change the description of MNIBBLES to be MNIBBLES - 4, similar to the convention of saying
MLEN - 1. Beforehand, the phrase "If MNIBBLES is 0, then ..." was unclear whether it meant MNIBBLES before the "plus 4" or after.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/231 **Author:** [@dsnet](https://github.com/dsnet) **Created:** 10/20/2015 **Status:** ✅ Merged **Merged:** 10/26/2015 **Merged by:** [@szabadka](https://github.com/szabadka) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`c996c06`](https://github.com/google/brotli/commit/c996c06e8d6d4f84a72dcb440de3a4c1dc073b76) Use consistent bit ordering and variable names - [`efeb59c`](https://github.com/google/brotli/commit/efeb59c4a2355f6eed11cb68f0bbc0922457c3a9) Placed explicit bit pattern table for MNIBBLES to avoid any doubts - [`0a9f65a`](https://github.com/google/brotli/commit/0a9f65aadc940c6b70f616debfde2826f1f4e878) s/static prefix code/variable length code/g - [`ec8756d`](https://github.com/google/brotli/commit/ec8756d79cc3b06fae06f6516a838bcba8277d74) Remove note at end of section 3.1 about switching prefix conventions ### 📊 Changes **1 file changed** (+30 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `docs/draft-alakuijala-brotli-07.nroff` (+30 -23) </details> ### 📄 Description If bits are to be parsed from left-to-right, then make the bit-strings left-justified. If bits are to be parsed from right-to-left, then make the bit-strings right-justified. Section 3.1, which describes how prefix codes work shows prefix codes that are "left-to-right", which is better for demonstrating how the work. However, most of the rest of the document uses a "right-to-left" convention. We should distinctly say at the end of section 3.1 that we are switching conventions. Thus, change the prefix code in section 3.5 to be "right-to-left" to be consistent with sections 9.1 and 9.2. Also, change the variable names in section 7.3 to be consistent with those used in section 10. Also, change the description of `MNIBBLES` to be `MNIBBLES - 4`, similar to the convention of saying `MLEN - 1`. Beforehand, the phrase "If MNIBBLES is 0, then ..." was unclear whether it meant MNIBBLES before the "plus 4" or after. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:51:06 +00:00

claunia referenced this issue

2026-01-29 20:54:02 +00:00

[PR #823] [CLOSED] Recompression #1429

claunia referenced this issue

2026-01-29 20:54:04 +00:00

[PR #823] Recompression #1433

Sign in to join this conversation.