[PR #240] [MERGED] Added note about invalid distance values #834

New Issue

claunia · 2026-01-29T20:51:08Z

claunia commented

2026-01-29 20:51:08 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/240
Author: @ende76
Created: 10/26/2015
Status: ✅ Merged
Merged: 10/27/2015
Merged by: @szabadka

Base: master ← Head: master

📝 Commits (2)

a05fa62 Added note about invalid distance values
d1cd34f Moved not about invalid distances up to 0-15 section

📊 Changes

2 files changed (+11 additions, -8 deletions)

View changed files

📝 docs/draft-alakuijala-brotli-07.nroff (+3 -0)
📝 docs/draft-alakuijala-brotli-07.txt (+8 -8)

📄 Description

It might be helpful for implementers to mention briefly conditions that qualify an input stream for rejection. This has already been applied in other places, so I believe it would make sense for distances as well.

It is my understanding that a negative distance, or a zero distance should be rejected as invalid.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/240 **Author:** [@ende76](https://github.com/ende76) **Created:** 10/26/2015 **Status:** ✅ Merged **Merged:** 10/27/2015 **Merged by:** [@szabadka](https://github.com/szabadka) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`a05fa62`](https://github.com/google/brotli/commit/a05fa62501eecc8faa58d69edfcb37f508e38644) Added note about invalid distance values - [`d1cd34f`](https://github.com/google/brotli/commit/d1cd34f6d9d3de867fb742b3303484271ef0044f) Moved not about invalid distances up to 0-15 section ### 📊 Changes **2 files changed** (+11 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `docs/draft-alakuijala-brotli-07.nroff` (+3 -0) 📝 `docs/draft-alakuijala-brotli-07.txt` (+8 -8) </details> ### 📄 Description It might be helpful for implementers to mention briefly conditions that qualify an input stream for rejection. This has already been applied in other places, so I believe it would make sense for distances as well. It is my understanding that a negative distance, or a zero distance should be rejected as invalid. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:51:08 +00:00

claunia referenced this issue

2026-01-29 20:54:05 +00:00

[PR #834] [MERGED] add execution time in verbose mode #1435

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#834