[PR #265] [CLOSED] Avoid integer overflow on x86_64-mingw, closes #264 #864

New Issue

claunia · 2026-01-29T20:51:17Z

claunia commented

2026-01-29 20:51:17 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/265
Author: @fasterthanlime
Created: 11/12/2015
Status: ❌ Closed

Base: master ← Head: mingw64-ull

📝 Commits (1)

2fe94d9 Avoid integer overflow on x86_64-mingw, closes #264

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 enc/write_bits.h (+1 -1)

📄 Description

Cf. #264 for an explanation of the actual problem.

I don't really have a good Visual Studio to test if that changes makes VC emit a warning - but at the very least I expect it to keep producing valid code.

In the future, would you consider adding mingw32 tests to your AppVeyor config? It's non-trivial, but doable. (Although, it would've have caught that particular issue, none of the test files triggered it at the tested qualities, or even at q=4).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/265 **Author:** [@fasterthanlime](https://github.com/fasterthanlime) **Created:** 11/12/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `mingw64-ull` --- ### 📝 Commits (1) - [`2fe94d9`](https://github.com/google/brotli/commit/2fe94d9da173b49f65ae89ef6ba0f4c8b2b14480) Avoid integer overflow on x86_64-mingw, closes #264 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `enc/write_bits.h` (+1 -1) </details> ### 📄 Description Cf. #264 for an explanation of the actual problem. I don't really have a good Visual Studio to test if that changes makes VC emit a warning - but at the very least I expect it to keep producing valid code. In the future, would you consider adding mingw32 tests to your AppVeyor config? It's non-trivial, but doable. (Although, it would've have caught that particular issue, none of the test files triggered it at the tested qualities, or even at q=4). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:51:17 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#864