[PR #265] Avoid integer overflow on x86_64-mingw, closes #264 #869

New Issue

claunia · 2026-01-29T20:51:19Z

claunia commented

2026-01-29 20:51:19 +00:00

Original Pull Request: https://github.com/google/brotli/pull/265

State: closed
Merged: No

Cf. #264 for an explanation of the actual problem.

I don't really have a good Visual Studio to test if that changes makes VC emit a warning - but at the very least I expect it to keep producing valid code.

In the future, would you consider adding mingw32 tests to your AppVeyor config? It's non-trivial, but doable. (Although, it would've have caught that particular issue, none of the test files triggered it at the tested qualities, or even at q=4).

**Original Pull Request:** https://github.com/google/brotli/pull/265 **State:** closed **Merged:** No --- Cf. #264 for an explanation of the actual problem. I don't really have a good Visual Studio to test if that changes makes VC emit a warning - but at the very least I expect it to keep producing valid code. In the future, would you consider adding mingw32 tests to your AppVeyor config? It's non-trivial, but doable. (Although, it would've have caught that particular issue, none of the test files triggered it at the tested qualities, or even at q=4).

claunia added the pull-request label 2026-01-29 20:51:19 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#869