[PR #311] [CLOSED] Make stdin/stdout work on Windows for tools/bro #910

New Issue

claunia · 2026-01-29T20:51:36Z

claunia commented

2026-01-29 20:51:36 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/311
Author: @fasterthanlime
Created: 2/5/2016
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

ac1be51 Let tools/bro work with stdin+stdout on Windows (mingw32)
c30c912 Use macro to switch stdin/stdout to binary mode so that tools/bro compiles on non-Windows platforms again

📊 Changes

1 file changed (+11 additions, -2 deletions)

View changed files

📝 tools/bro.cc (+11 -2)

📄 Description

The code in master works well on Linux/OSX, not so well on Windows. This PR makes it work for all 3 main platforms. Props to #174 for giving helpful hints!

Tested on OSX 10.11.3 with clang 7.0.2, and Windows 10 with msys2, gcc 5.2.0

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/311 **Author:** [@fasterthanlime](https://github.com/fasterthanlime) **Created:** 2/5/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`ac1be51`](https://github.com/google/brotli/commit/ac1be51fc67a0367af39901c0ed8e932cdb078ec) Let tools/bro work with stdin+stdout on Windows (mingw32) - [`c30c912`](https://github.com/google/brotli/commit/c30c9120627137a5930af22b3acf7f80f9e56f3f) Use macro to switch stdin/stdout to binary mode so that tools/bro compiles on non-Windows platforms again ### 📊 Changes **1 file changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tools/bro.cc` (+11 -2) </details> ### 📄 Description The code in master works well on Linux/OSX, not so well on Windows. This PR makes it work for all 3 main platforms. Props to #174 for giving helpful hints! Tested on OSX 10.11.3 with clang 7.0.2, and Windows 10 with msys2, gcc 5.2.0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:51:36 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#910