[PR #331] [MERGED] Fix build with -Wmissing-declarations. #927

New Issue

claunia · 2026-01-29T20:51:42Z

claunia commented

2026-01-29 20:51:42 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/331
Author: @PiotrSikora
Created: 3/19/2016
Status: ✅ Merged
Merged: 3/22/2016
Merged by: @eustas

Base: master ← Head: missing_declarations

📝 Commits (1)

501cb86 Fix build with -Wmissing-declarations.

📊 Changes

10 files changed (+185 additions, -180 deletions)

View changed files

📝 enc/backward_references.cc (+37 -37)
📝 enc/block_splitter.cc (+2 -2)
📝 enc/brotli_bit_stream.cc (+44 -44)
📝 enc/compress_fragment.cc (+22 -19)
📝 enc/compress_fragment_two_pass.cc (+9 -9)
📝 enc/encode.cc (+62 -60)
📝 enc/entropy_encode.cc (+3 -3)
📝 enc/literal_cost.cc (+2 -2)
📝 shared.mk (+2 -2)
📝 tools/bro.cc (+2 -2)

📄 Description

While there, add -Wmissing-prototypes and -Wmissing-declarations
to shared.mk in order to catch similar errors in the future.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/331 **Author:** [@PiotrSikora](https://github.com/PiotrSikora) **Created:** 3/19/2016 **Status:** ✅ Merged **Merged:** 3/22/2016 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `missing_declarations` --- ### 📝 Commits (1) - [`501cb86`](https://github.com/google/brotli/commit/501cb861725d29d72b2c7ca5206e9dadcf871e55) Fix build with -Wmissing-declarations. ### 📊 Changes **10 files changed** (+185 additions, -180 deletions) <details> <summary>View changed files</summary> 📝 `enc/backward_references.cc` (+37 -37) 📝 `enc/block_splitter.cc` (+2 -2) 📝 `enc/brotli_bit_stream.cc` (+44 -44) 📝 `enc/compress_fragment.cc` (+22 -19) 📝 `enc/compress_fragment_two_pass.cc` (+9 -9) 📝 `enc/encode.cc` (+62 -60) 📝 `enc/entropy_encode.cc` (+3 -3) 📝 `enc/literal_cost.cc` (+2 -2) 📝 `shared.mk` (+2 -2) 📝 `tools/bro.cc` (+2 -2) </details> ### 📄 Description While there, add -Wmissing-prototypes and -Wmissing-declarations to shared.mk in order to catch similar errors in the future. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:51:42 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#927