[PR #332] [CLOSED] build: create an encoder and decoder library #929

New Issue

claunia · 2026-01-29T20:51:42Z

claunia commented

2026-01-29 20:51:42 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/332
Author: @bagder
Created: 3/20/2016
Status: ❌ Closed

Base: master ← Head: libbrotli

📝 Commits (1)

1e824ce build: create an encoder and decoder library

📊 Changes

5 files changed (+148 additions, -0 deletions)

View changed files

➕ Makefile.am (+89 -0)
➕ autogen.sh (+22 -0)
➕ configure.ac (+15 -0)
➕ libbrotlidec.pc.in (+11 -0)
➕ libbrotlienc.pc.in (+11 -0)

📄 Description

Based on commit https://github.com/bagder/libbrotli/commit/e992cce7a17 after initial discussion in issue #326.

First take. This version unfortunately duplicate the list of sources from enc/Makefile and dec/Makefile, which I would rather avoid. It also doesn't use the shared.mk magic that the existing Makefiles use.

Run

$ ./autogen.sh
$ ./configue
$ make
$ make install

Any feedback on the approach? I decided to put the files in the root dir since that is a common convention. Let me know what you think.

docs

make install puts the headers in $prefix/install/dec and $prefix/install/inc subdirectories to be used for applications.

This setup builds one encoder lib and one decoder lib. libbrotlidec.pc and libbrotlienc.pc are generated to help applications know how to link with them.

The Makefile.am file needs to be maintained and state the correct SONAME numbers for the generated shared libraries. They say 1.0.0. for both, but its really up to you guys to decide how to do them.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/332 **Author:** [@bagder](https://github.com/bagder) **Created:** 3/20/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `libbrotli` --- ### 📝 Commits (1) - [`1e824ce`](https://github.com/google/brotli/commit/1e824ce5035f37f5cf59431c6c9025723e07136d) build: create an encoder and decoder library ### 📊 Changes **5 files changed** (+148 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `Makefile.am` (+89 -0) ➕ `autogen.sh` (+22 -0) ➕ `configure.ac` (+15 -0) ➕ `libbrotlidec.pc.in` (+11 -0) ➕ `libbrotlienc.pc.in` (+11 -0) </details> ### 📄 Description Based on commit https://github.com/bagder/libbrotli/commit/e992cce7a17 after initial discussion in issue #326. First take. This version unfortunately duplicate the list of sources from enc/Makefile and dec/Makefile, which I would rather avoid. It also doesn't use the `shared.mk` magic that the existing Makefiles use. Run ``` $ ./autogen.sh $ ./configue $ make $ make install ``` Any feedback on the approach? I decided to put the files in the root dir since that is a common convention. Let me know what you think. # docs `make install` puts the headers in $prefix/install/dec and $prefix/install/inc subdirectories to be used for applications. This setup builds one encoder lib and one decoder lib. `libbrotlidec.pc` and `libbrotlienc.pc` are generated to help applications know how to link with them. The `Makefile.am` file needs to be maintained and state the correct SONAME numbers for the generated shared libraries. They say 1.0.0. for both, but its really up to you guys to decide how to do them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:51:42 +00:00

claunia referenced this issue

2026-01-29 20:54:27 +00:00

[PR #929] [MERGED] Fix -Werror=vla-parameter errors with GCC 11.2.0 #1505

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#929