[PR #334] [CLOSED] Fix build with -Wshadow. #931

New Issue

claunia · 2026-01-29T20:51:43Z

claunia commented

2026-01-29 20:51:43 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/334
Author: @PiotrSikora
Created: 3/24/2016
Status: ❌ Closed

Base: master ← Head: shadow

📝 Commits (1)

6210596 Fix build with -Wshadow.

📊 Changes

5 files changed (+42 additions, -41 deletions)

View changed files

📝 enc/block_splitter.cc (+3 -3)
📝 enc/compress_fragment.cc (+10 -10)
📝 enc/compress_fragment_two_pass.cc (+10 -10)
📝 enc/entropy_encode.cc (+3 -3)
📝 enc/literal_cost.cc (+16 -15)

📄 Description

Local variable shadowing makes code quite confusing in most cases.

I'm not sure if the new variable names are correct in all those cases,
so feel free to rename them.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/334 **Author:** [@PiotrSikora](https://github.com/PiotrSikora) **Created:** 3/24/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `shadow` --- ### 📝 Commits (1) - [`6210596`](https://github.com/google/brotli/commit/6210596ed29e4da26668d0a6a1bfe7072aec2501) Fix build with -Wshadow. ### 📊 Changes **5 files changed** (+42 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `enc/block_splitter.cc` (+3 -3) 📝 `enc/compress_fragment.cc` (+10 -10) 📝 `enc/compress_fragment_two_pass.cc` (+10 -10) 📝 `enc/entropy_encode.cc` (+3 -3) 📝 `enc/literal_cost.cc` (+16 -15) </details> ### 📄 Description Local variable shadowing makes code quite confusing in most cases. I'm not sure if the new variable names are correct in all those cases, so feel free to rename them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:51:43 +00:00

claunia closed this issue

2026-01-29 20:51:43 +00:00

claunia referenced this issue

2026-01-29 20:54:27 +00:00

[PR #931] [MERGED] Suppress cmake's CMP0048 warning #1506

claunia referenced this issue

2026-01-29 20:54:28 +00:00

[PR #931] Suppress cmake's CMP0048 warning #1510

Sign in to join this conversation.