[PR #340] [CLOSED] Vs2012 fix #935

New Issue

claunia · 2026-01-29T20:51:44Z

claunia commented

2026-01-29 20:51:44 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/340
Author: @1100101
Created: 4/22/2016
Status: ❌ Closed

Base: master ← Head: vs2012_fix

📝 Commits (2)

762b76b Fix compilation with VS2012
c338ae8 Correct the Visual Studio version in the comment

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 enc/fast_log.h (+2 -2)

📄 Description

The brotli code currently does not compile with Visual Studio 2012, because the code assumes that the log2 function is supported by VIsual Studio 2012 and newer, which is not true.

This PR fixes the preprocessor check, so the workaround code is used with Visual Studio 2012 as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/340 **Author:** [@1100101](https://github.com/1100101) **Created:** 4/22/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `vs2012_fix` --- ### 📝 Commits (2) - [`762b76b`](https://github.com/google/brotli/commit/762b76ba8e2c99d4fb41f44c957ca10aea5d69f5) Fix compilation with VS2012 - [`c338ae8`](https://github.com/google/brotli/commit/c338ae829490e4a91c5fe64f79f8c21212eed47e) Correct the Visual Studio version in the comment ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `enc/fast_log.h` (+2 -2) </details> ### 📄 Description The brotli code currently does not compile with Visual Studio 2012, because the code assumes that the `log2` function is supported by VIsual Studio 2012 and newer, which is not true. This PR fixes the preprocessor check, so the workaround code is used with Visual Studio 2012 as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:51:44 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#935