starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-09-22 22:56:08 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

[PR #340] Vs2012 fix #937

New Issue
Closed
opened 2026-01-29 20:51:44 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 20:51:44 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/google/brotli/pull/340

State: closed
Merged: No

The brotli code currently does not compile with Visual Studio 2012, because the code assumes that the log2 function is supported by VIsual Studio 2012 and newer, which is not true.

This PR fixes the preprocessor check, so the workaround code is used with Visual Studio 2012 as well.

**Original Pull Request:** https://github.com/google/brotli/pull/340 **State:** closed **Merged:** No --- The brotli code currently does not compile with Visual Studio 2012, because the code assumes that the `log2` function is supported by VIsual Studio 2012 and newer, which is not true. This PR fixes the preprocessor check, so the workaround code is used with Visual Studio 2012 as well.
claunia added the pull-request label 2026-01-29 20:51:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#937
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?