[PR #341] [MERGED] Fix compilation with VS2012 #939

New Issue

claunia · 2026-01-29T20:51:45Z

claunia commented

2026-01-29 20:51:45 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/341
Author: @1100101
Created: 4/22/2016
Status: ✅ Merged
Merged: 4/22/2016
Merged by: @eustas

Base: master ← Head: fix_vs2012_compilation

📝 Commits (1)

d9a268c Fix compilation with VS2012

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 enc/fast_log.h (+2 -2)

📄 Description

The brotli code currently does not compile with Visual Studio 2012, because the code assumes that the log2 function is supported by VIsual Studio 2012 and newer, which is not true.

This PR fixes the preprocessor check, so the workaround code is used with Visual Studio 2012 as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/341 **Author:** [@1100101](https://github.com/1100101) **Created:** 4/22/2016 **Status:** ✅ Merged **Merged:** 4/22/2016 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `fix_vs2012_compilation` --- ### 📝 Commits (1) - [`d9a268c`](https://github.com/google/brotli/commit/d9a268c60c3e656c4de4068095f4c68a8392d4cb) Fix compilation with VS2012 ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `enc/fast_log.h` (+2 -2) </details> ### 📄 Description The brotli code currently does not compile with Visual Studio 2012, because the code assumes that the `log2` function is supported by VIsual Studio 2012 and newer, which is not true. This PR fixes the preprocessor check, so the workaround code is used with Visual Studio 2012 as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:51:45 +00:00

claunia closed this issue

2026-01-29 20:51:45 +00:00

claunia referenced this issue

2026-01-29 20:54:27 +00:00

[PR #939] [MERGED] Prepare for copybara #1504

claunia referenced this issue

2026-01-29 20:54:27 +00:00

[PR #939] Prepare for copybara #1507

Sign in to join this conversation.