[PR #379] [MERGED] Fix VS build problems #979

Open
opened 2026-01-29 20:51:56 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/379
Author: @eustas
Created: 6/17/2016
Status: Merged
Merged: 6/17/2016
Merged by: @eustas

Base: masterHead: master


📝 Commits (1)

📊 Changes

12 files changed (+127 additions, -100 deletions)

View changed files

📝 .gitignore (+1 -1)
📝 BUILD (+4 -7)
📝 MANIFEST.in (+1 -1)
📝 Makefile (+2 -2)
📝 buildfiles/gmake/Makefile (+0 -0)
📝 buildfiles/gmake/bro.make (+11 -11)
📝 buildfiles/gmake/brotli_common.make (+4 -4)
📝 buildfiles/gmake/brotli_dec.make (+4 -4)
📝 buildfiles/gmake/brotli_enc.make (+4 -4)
📝 configure (+2 -2)
📝 premake5.lua (+7 -4)
📝 tools/bro.c (+87 -60)

📄 Description

  • rename build -> buildfiles to avoid clashing with BUILD
  • set binary mode for stdin/out in bro
  • convert bro to C

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/379 **Author:** [@eustas](https://github.com/eustas) **Created:** 6/17/2016 **Status:** ✅ Merged **Merged:** 6/17/2016 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`b32cefe`](https://github.com/google/brotli/commit/b32cefe1607b9e349bcceca9d4458775e1647880) Fix VS build problems: ### 📊 Changes **12 files changed** (+127 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) 📝 `BUILD` (+4 -7) 📝 `MANIFEST.in` (+1 -1) 📝 `Makefile` (+2 -2) 📝 `buildfiles/gmake/Makefile` (+0 -0) 📝 `buildfiles/gmake/bro.make` (+11 -11) 📝 `buildfiles/gmake/brotli_common.make` (+4 -4) 📝 `buildfiles/gmake/brotli_dec.make` (+4 -4) 📝 `buildfiles/gmake/brotli_enc.make` (+4 -4) 📝 `configure` (+2 -2) 📝 `premake5.lua` (+7 -4) 📝 `tools/bro.c` (+87 -60) </details> ### 📄 Description - rename build -> buildfiles to avoid clashing with BUILD - set binary mode for stdin/out in bro - convert bro to C --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 20:51:56 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#979